Add websocket server launcher #41
Conversation
| @@ -12,41 +12,6 @@ The server consists of three components: | |||
| The main target environment is node, nevertheless, all components are implemented in an ismorphic fashion and also provide | |||
| an entrypoint to target browser environments (e.g. running the server in a web worker) | |||
|
|
|||
| ## Integration & Features | |||
There was a problem hiding this comment.
Should we add some information about the websocket server in ## Start & Debug?
package.json
Outdated
| @@ -20,6 +20,7 @@ | |||
| "publish:next": "SHA=$(git rev-parse --short HEAD) && lerna publish preminor --exact --canary --preid next.${SHA} --dist-tag next --no-git-reset --no-git-tag-version --no-push --ignore-scripts --yes --no-verify-access", | |||
| "publish:prepare": "lerna version --ignore-scripts --yes --no-push", | |||
| "start": "yarn --cwd examples/workflow-server start", | |||
| "start:websocket": "yarn --cwd examples/workflow-server start;websocket", | |||
There was a problem hiding this comment.
| "start:websocket": "yarn --cwd examples/workflow-server start;websocket", | |
| "start:websocket": "yarn --cwd examples/workflow-server start:websocket", |
|
|
||
| const START_UP_COMPLETE_MSG = '[GLSP-Server]:Startup completed.'; |
There was a problem hiding this comment.
| const START_UP_COMPLETE_MSG = '[GLSP-Server]:Startup completed.'; | |
| export const START_UP_COMPLETE_MSG = '[GLSP-Server]:Startup completed.'; | |
| @@ -20,7 +20,7 @@ import { GLSPServerLauncher } from '../../common/launch/glsp-server-launcher'; | |||
| import { GLSPServer, JsonRpcGLSPServer } from '../../common/protocol/glsp-server'; | |||
| import { Logger } from '../../common/utils/logger'; | |||
|
|
|||
| const START_UP_COMPLETE_MSG = '[GLSP-Server]:Startup completed. Accepting requests on port:'; | |||
| export const START_UP_COMPLETE_MSG = '[GLSP-Server]:Startup completed. Accepting requests on port:'; | |||
There was a problem hiding this comment.
| export const START_UP_COMPLETE_MSG = '[GLSP-Server]:Startup completed. Accepting requests on port:'; | |
| export const START_UP_COMPLETE_MSG = '[GLSP-Server]:Startup completed. Accepting requests on port:'; | |
| server.setTimeout(0); | ||
| return server; | ||
| } | ||
| protected stop(): MaybePromise<void> { |
There was a problem hiding this comment.
| protected stop(): MaybePromise<void> { | |
| protected stop(): MaybePromise<void> { |
| @injectable() | ||
| export abstract class GLSPServerLauncher<T = undefined> { | ||
| export abstract class GLSPServerLauncher<T> { |
There was a problem hiding this comment.
Should we provide a protected disposeOnStop = new DisposableCollection(); to provide a default stop behavior that can be filled up by adding disposables to this collection on start or run? Maybe this launcher should also implement Disposable.
|
|
||
| protected createHttpServer(port: number, host?: string): http.Server { | ||
| const server = http.createServer((req, res) => { | ||
| const body = http.STATUS_CODES[426]; |
There was a problem hiding this comment.
I had to look up that status code so I think it would be great to either import some package that already provides them or at least create a constant for the one we use const STATUS_UPGRADE_REQUIRED = 426 or something similar.
| "${workspaceRoot}/examples/workflow-server/*/lib/**/*.js", | ||
| "${workspaceRoot}/packages/**/*/lib/**/*.js" | ||
| ], | ||
| "sourceMapPathOverrides": { |
There was a problem hiding this comment.
Could you maybe add a short comment on why this is necessary and what the deal is with the webpack and meteor URIs?
Co-authored-by: Martin Fleck <mfleck@eclipsesource.com>
Requires eclipse-glsp/glsp-client#215
Fixes eclipse-glsp/glsp#945