Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adjust server startup to use autoassigned ports #42

Merged
merged 1 commit into from
May 3, 2023

Conversation

xai
Copy link
Member

@xai xai commented Apr 6, 2023

This sets the default port to 0, which will cause the server to automatically assign a port. The port is then printed to the console in the startup message and can be parsed by clients.

Part of eclipse-glsp/glsp#965

Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only one minor nitpick regarding the changelog

CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
examples/workflow-server/package.json Outdated Show resolved Hide resolved
examples/workflow-server/package.json Outdated Show resolved Hide resolved
This sets the default port to 0, which will cause the server to
automatically assign a port. The port is then printed to the console
in the startup message and can be parsed by clients.

Signed-off-by: Olaf Lessenich <olessenich@eclipsesource.com>
Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@tortmayr tortmayr merged commit dc6b980 into eclipse-glsp:main May 3, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants