Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLSP-1022: Update to TS5 and inversify 6 #48

Merged
merged 1 commit into from
Jun 20, 2023
Merged

GLSP-1022: Update to TS5 and inversify 6 #48

merged 1 commit into from
Jun 20, 2023

Conversation

tortmayr
Copy link
Contributor

@tortmayr tortmayr commented May 27, 2023

  • Update to typescript 5
  • Update to inversify 6. Inversify is now a peerDependency (^6.0.0). A matching version has to be provided by consuming projects.
  • Adapt codebase to new inversify API
  • Rework elk-layouit package to remove unnecessary dependency in sprotty-elk
    Part of Update to inversify 6 and TS 5 glsp#1022
    (uses locally published glsp packages. needs to be adapted once the offical packages are available)

Requires eclipse-glsp/glsp-client#253

- Update to typescript 5
- Update to inversify 6. Inversify is now a peerDependency (^6.0.0). A matching version has to be provided by consuming projects.
- Adapt codebase to new inversify API
- Rework elk-layouit package to remove unnecessary dependency in `sprotty-elk`
Part of eclipse-glsp/glsp#1023
(uses locally published glsp packages. needs to be adapted once the offical packages are available)

Requires eclipse-glsp/glsp-client#253
@tortmayr tortmayr marked this pull request as ready for review June 8, 2023 12:20
Copy link
Contributor

@martin-fleck-at martin-fleck-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me in general. However, the adaptation of the linting message seems odd to me, please double check.

packages/server/src/common/utils/args-util.ts Show resolved Hide resolved
.eslintrc.js Show resolved Hide resolved
Copy link
Contributor

@martin-fleck-at martin-fleck-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tortmayr tortmayr merged commit e49c816 into main Jun 20, 2023
6 checks passed
@tortmayr tortmayr deleted the glsp-1022 branch June 20, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants