Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLSP-1101: Fix Windows path conversion #55

Merged
merged 1 commit into from
Sep 4, 2023
Merged

GLSP-1101: Fix Windows path conversion #55

merged 1 commit into from
Sep 4, 2023

Conversation

tortmayr
Copy link
Contributor

@tortmayr tortmayr commented Sep 4, 2023

Ensure leading shashes in File urls are properly handled under Windows.
Also: Fix rimraf command that was not working under Windows
Fixes eclipse-glsp/glsp#1101

Copy link
Member

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! 👍

Can't test this directly, but looks good code-wise.

@tortmayr tortmayr merged commit bc2649d into main Sep 4, 2023
6 checks passed
Ensure leading shashes in File urls are properly handled under Windows.
Also: Fix rimraf command that was not working under Windows
Fixes eclipse-glsp/glsp#1101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows Pathing Issues in the Workflow-Standalone Example
2 participants