Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add args to SModelElements #100

Merged
merged 2 commits into from
Mar 1, 2021
Merged

Add args to SModelElements #100

merged 2 commits into from
Mar 1, 2021

Conversation

planger
Copy link
Member

@planger planger commented Feb 23, 2021

This allows to transfer custom information from the server to the client
in the GModel without having to extend the GModel types with custom
classes.

E.g.
modelState.getRoot().getArgs().put("test", true);
modelState.getRoot().getArgs().put("test2", "a string 2");

eclipse-glsp/glsp#194

This allows to transfer custom information from the server to the client
in the GModel without having to extend the GModel types with custom
classes.

E.g.
    modelState.getRoot().getArgs().put("test", true);
    modelState.getRoot().getArgs().put("test2", "a string 2");

eclipse-glsp/glsp#194
Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. However, we should probably update the Copyright headers of the generated files (2019-2021).

@planger planger requested a review from tortmayr March 1, 2021 15:14
@tortmayr tortmayr merged commit 398772b into master Mar 1, 2021
@tortmayr tortmayr deleted the planger/issues/194 branch March 1, 2021 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants