Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#260 Update to Guice 5.0.1 #119

Merged
merged 1 commit into from
Aug 3, 2021
Merged

#260 Update to Guice 5.0.1 #119

merged 1 commit into from
Aug 3, 2021

Conversation

tortmayr
Copy link
Contributor

@tortmayr tortmayr commented Aug 3, 2021

Update the dependencies to use the latest Guice version available in Orbit (5.0.1) and update the target platform definition to Eclipse 2021-03 to be in line with the TPD of the eclipse-integration.

This indirectly also enforces updates of jupiter, elk and guava dependencies.
This PR contains a workaround to bypass the guava version restriction for elk maven dependencies that can be removed once ELK 0.8.0 is released (this is tracked in eclipse-glsp/glsp/issues/#265)

Resolves eclipse-glsp/glsp/issues/260

Update the dependencies to use the latest Guice version available in Orbit (5.0.1) and update the target platform definition to Eclipse 2021-03 to be in line with the TPD of the eclipse-integration.

This indirectly also enforces updates of jupiter, elk and guava dependencies.
This PR contains a workaround to bypass the guava version restriction for elk maven dependencies. This can be removed once ELK 0.8.0 is released (this is tracked in  eclipse-glsp/glsp/issues/#265)

Resolves eclipse-glsp/glsp/issues/260
Copy link
Member

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! 👍

@tortmayr tortmayr merged commit ab03f57 into master Aug 3, 2021
@tortmayr tortmayr deleted the tortmayr/issues/260 branch August 3, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we update guice?
2 participants