#315 Refactor base protocol #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the great work! Looks good, local build and tests work fine! |
tortmayr
force-pushed
the
tortmayr/di-rework
branch
from
3b04909
to
9c02d77
Compare
|
Thanks for the review Philip, I have made some additional changes to the protocol. Could you please re-review? |
planger
approved these changes
Aug 16, 2021
plugins/org.eclipse.glsp.server/src/org/eclipse/glsp/server/actions/Action.java
Outdated
Show resolved
Hide resolved
plugins/org.eclipse.glsp.server/src/org/eclipse/glsp/server/actions/ActionMessage.java
Outdated
Show resolved
Hide resolved
tortmayr
force-pushed
the
tortmayr/di-rework
branch
from
d0f0752
to
5605160
Compare
Refactor the base communication protocol to support initializing and disposing a client session for a given language. The method parameters are encapsulated in dedicated parameter objects to provide a stable API. Refactor the existing `initialize` method to return void instead of a boolean and use a generic args map for custom arguments instead of a dedicated object. In addition, the protocol version that is implemented by the client is now passed as part of the `InitializeParameters`
Other fixes/improvements:
- Fixed code template for new files. Used ${year} variable for the copyright header instead of hard coded 2020 string.
- Refactor `ActionRegistry` to use Class<Action> instead of dedicated action instances.
- Fixed bug in "Disposable". Previously the 'disposed' flag was not set correctly
- Refactor `ClientOptions` util class and extract a generic `MapUtil` class.
- Merge `GLSPServer` and `GLSPJsonRpcServer` interfaces. There is no need of a dediacted subinterface because the GLSPServer interface is already tailored for JSON-RPC and not generically reuseable.
- Improve documentation for protocol components and related classes.
Part of eclipse-glsp/glsp/issues/315
tortmayr
force-pushed
the
tortmayr/di-rework
branch
from
5605160
to
19d6697
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the base communication protocol to support initializing and disposing a client session for a given language. The method parameters are encapsulated in dedicated parameter objects to provide a stable API. Refactor the existing
initializemethod to return void instead of a boolean and use a generic args map for custom arguments instead of a dedicated object. In addition, the protocol version that is implemented by the client is now passed as part of theInitializeParametersOther fixes/improvements:
ActionRegistryto use Class instead of dedicated action instances.ClientOptionsutil class and extract a genericMapUtilclass.Part of eclipse-glsp/glsp/issues/315