#421 Improve implementation of DefaultGLSPServer #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tortmayr
force-pushed
the
tortmayr/multi-client
branch
from
77e0579
to
8d4c28a
Compare
#421 Improve implementation of DefaultGLSPServer - Update `DefaultGLSPServer` implementation so that request methods throw `ResponseErrorExceptions` instead of `GLSPServerExceptions` (see also [LSP4J core concepts](https://github.com/eclipse/lsp4j/blob/main/documentation/jsonrpc.md#response-errors) -Refactor and rename `createClientSession` method of `ClientSessionManager` to `getOrCreateClientSession` - Update behavior of `initialize` and `initializeClientSession` requests to enable multiple invocations with the same parameters. #423 Rework "ServerConnectionListener" Refactor `ServerConnectionListener` to `GLSPServerListener` and allow listening to the following events: - GLSPClient proxy connection - Server initialization - Server shutdown This also means that the server no longer needs to new which resources it should dispose on shutdown. Instead classes that should be disposed can listen on the shutdown-event and dispose themselves (e.g. ClientSessionManager) Also: Improve general extensibility by changing the visibility of private fields of classes in the websocket package to `protected` Improve interface documentation and mention when methods should notify a listener. Fixes eclipse-glsp/glsp/issues/421 Fixes eclipse-glsp/glsp/issues/423 Required for eclipse-glsp/glsp/issues/418
tortmayr
force-pushed
the
tortmayr/multi-client
branch
from
8d4c28a
to
90b9057
Compare
planger
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#421 Improve implementation of DefaultGLSPServer
DefaultGLSPServerimplementation so that request methods throwResponseErrorExceptionsinstead ofGLSPServerExceptions(see also LSP4J core concepts-Refactor and rename
createClientSessionmethod ofClientSessionManagertogetOrCreateClientSessioninitializeandinitializeClientSessionrequests to enable multiple invocations with the same parameters.#423 Rework "ServerConnectionListener"
Refactor
ServerConnectionListenertoGLSPServerListenerand allow listening to the following events:This also means that the server no longer needs to new which resources it should dispose on shutdown. Instead classes that should be disposed can listen on the shutdown-event and dispose themselves (e.g. ClientSessionManager)
Also: Improve general extensibility by changing the visibility of private fields of classes in the websocket package to
protectedImprove interface documentation and mention when methods should notify a listener.
Fixes eclipse-glsp/glsp/issues/421
Fixes eclipse-glsp/glsp/issues/423
Required for eclipse-glsp/glsp/issues/418