-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve styling and simplify workflow example #148
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Philip!
While testing the workflow example, I recognized that two validation features do not work anymore for the Workflow example:
The label edit validation should prompt Name should be unique
while typing. Currently, this only works for the Push
node, as here the name
and label text
value are identical. In general, the name
and label text
values differ for most task nodes in the example workflow model.
As I could observe, the label edit changes the label's text and the validator checks the name of a task node instead. Could we align the behavior to get the correct label edit validation?
...lipse.glsp.example.workflow/src/org/eclipse/glsp/example/workflow/utils/WorkflowBuilder.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update Philip! The label edit validation works now as expected! 🎉
Unfortunately I didn't elaborate my comment enough.
The validation in the WorkflowModelValidator
(if a task name starts with an upper case letter) is also broken, because there is no dedicated compartment in the taskNode anymore (see validateTaskNode_labelStartsUpperCase
).
Could you have another look? Thanks!
Thanks for the great catch! I fixed the workflow validator in 453b347. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you Philip for the quick fix! Looks great! 👍
I would have one final minor request, I just realized the file headers should be updated to -2022
. Thanks!
Thanks, I updated the headers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Philip! 🎉
eclipse-glsp/glsp#492