#571 Properly dispose temporary configuration session injectors #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the initial configuration of the `DefaultServerGsonConfigurator` to actually create temporary client sessions to retrieve the corresponding `ServerConfigurationContribution`. This session can then be safely disposed once its no longer needed (i.e. the configuration is completed). By disposing the client session we ensure that all temporary created resources like the `ActionDispatcher` (thread) are properly disposed. In addition, the acutal configuration logic is refactored into a protected method that is called from the constructor. This makes it easier for subclasses to customize the configuration behavior. Fixes eclipse-glsp/glsp/issues/571
tortmayr
requested review from
martin-fleck-at,
ndoschek and
planger
and removed request for
planger,
martin-fleck-at and
ndoschek
martin-fleck-at
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the initial configuration of the
DefaultServerGsonConfiguratorto actually create temporary client sessions to retrieve the correspondingServerConfigurationContribution. This session can then be safely disposed once its no longer needed (i.e. the configuration is completed).By disposing the client session we ensure that all temporary created resources like the
ActionDispatcher(thread) are properly disposed.In addition, the acutal configuration logic is refactored into a protected method that is called from the constructor. This makes it easier for subclasses to customize the configuration behavior.
Fixes eclipse-glsp/glsp/issues/571