Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that LayoutEngine is only injected into an optional field #153

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

planger
Copy link
Member

@planger planger commented Mar 22, 2022

Otherwise Guice would through an error if no layout engine is bound by
the module (which is fine however).

Fixes eclipse-glsp/glsp#600

Otherwise Guice would through an error if no layout engine is bound by
the module (which is fine however).

Fixes eclipse-glsp/glsp#600
@planger planger requested a review from tortmayr March 22, 2022 15:40
Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fast fix.

@planger planger merged commit 7e41611 into master Mar 24, 2022
@planger planger deleted the planger/issues/600 branch March 24, 2022 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Null LayoutEngine causes exception
2 participants