#622 Init org.eclipse.glsp.server.emf and add example models #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-fleck-at
force-pushed
the
issues/622
branch
2 times, most recently
from
4167baf
to
b23d3c3
Compare
martin-fleck-at
force-pushed
the
issues/622
branch
from
8cc55b2
to
399b9f5
Compare
Init project org.eclipse.glsp.server.emf - Add notation model (a copy of org.eclipse.emfcloud.modelserver.glsp.integration) Add reusable API for EMF with or without notation model EMF with semantic model: - Provide editing domain factory for resource set and command stack - Provide indexer that handles semantic model elements - Provide semantic ID generator to be used when creating the index - Provide base class for GModelFactory - Provide class for semantic model loading - Provide UUID XMI resource factory if XMI ids are used as identifiers EMF with semantic and notation model: - Provide indexer that handles semantic and notation model elements - Provide semantic ID converter to resolve semantic id to EObject - Provide base class for GModelFactory - Provide class for semantic and notation model loading Refactorings: - Only apply layout options if a custom layout is actually set - Provide ComputedBounds, Save, UndoRedo support by default - GModelState: -- Refactor 'setRoot' to only actually set the root property --- For any root-dependent changes 'updateRoot' should be used -- Remember index, initialize with empty and update with root change Co-authored-by: Martin Fleck <mfleck@eclipsesource.com> Part of eclipse-glsp/glsp#622 Contributed on behalf of STMicroelectronics.
|
Cool thanks 👍 . ModelState#updateRoot was the method we were missing. So we always had to removed all elements before syncing again from our model. Because with setRoot we otherwise lost the Command Stack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of eclipse-glsp/glsp#622
Contributed on behalf of STMicroelectronics.