Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#579 Update to log4j 2.17.1 #163

Merged
merged 3 commits into from
May 5, 2022
Merged

#579 Update to log4j 2.17.1 #163

merged 3 commits into from
May 5, 2022

Conversation

ndoschek
Copy link
Contributor

@ndoschek ndoschek commented May 4, 2022

  • Update to org.apache.logging.log4j version 2.17.1
    • Migrate dependencies to log4j2
    • Migrate usage of logger to log4j2 and align naming to LOGGER
    • Migrate log configuration and introduce rolling log file policy
  • Update target platform to latest 2022-03 release
  • Adapt fatjar build
    • Setup fatjar to use multi-release jars to overcome logging issues while jar execution
    • Fix warnings related to overlapping classes during fatjar generation
  • Ensure logging is configured for all server use cases on startup
    • Provide start methods to allow easier log configuration
  • Add Log4j2Logger redirection for jetty server in case of websocket server usage
    • This is a copy from the org.apache.logging.log4j/log4j-appserver module, as this is not available as plugin.
  • Improve help text for CLI usage
    • Add short program arguments for single letter argument usage
  • Fix fragment host version for org.eclipse.glsp.graph.test in manifest file
  • Update README

Resolves eclipse-glsp/glsp#579

- Update to org.apache.logging.log4j version 2.17.1
  - Migrate dependencies to log4j2
  - Migrate usage of logger to log4j2 and align naming to LOGGER
  - Migrate log configuration and introduce rolling log file policy
- Update target platform to latest 2022-03 release
- Adapt fatjar build
  - Setup fatjar to use multi-release jars to overcome logging issues while jar execution
  - Fix warnings related to overlapping classes during fatjar generation
- Ensure logging is configured for all server use cases on startup
  - Provide start methods to allow easier log configuration
- Add Log4j2Logger redirection for jetty server in case of websocket server usage
  - This is a copy from the org.apache.logging.log4j/log4j-appserver module, as this is not available as plugin.
- Improve help text for CLI usage
  - Add short program arguments for single letter argument usage
- Fix fragment host version for org.eclipse.glsp.graph.test in manifest file
- Update README

Resolves eclipse-glsp/glsp#579
@ivy-cst
Copy link
Contributor

ivy-cst commented May 4, 2022

@ndoschek Cool that the newest libraries are used with this change. Just one thing. I relaxed that glsp depends on log4j with Import-Package instead of Require-Bundle so that the log4j classes can also come form another bundle than org.apache.log4j. See eclipse-glsp/glsp/issues/430. Would be nice if you could also depend on log4j2 with just Import-Package. Thanks.

@ndoschek
Copy link
Contributor Author

ndoschek commented May 5, 2022

Thanks @ivy-cst! I updated my changes and import the packages now instead of requiring the bundle.

Copy link
Member

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ndoschek, looks good to me!
I tested building and running the fatjar. That worked fine. 👍

README.md Outdated Show resolved Hide resolved
Co-authored-by: Philip Langer <planger@eclipsesource.com>
@ndoschek
Copy link
Contributor Author

ndoschek commented May 5, 2022

Thanks @planger, yes I agree - I updated with your suggested change

@ndoschek ndoschek merged commit 39ee6c9 into master May 5, 2022
@ndoschek ndoschek deleted the issues/579 branch May 5, 2022 14:58
planger added a commit to eclipse-glsp/glsp-eclipse-integration that referenced this pull request May 23, 2022
planger added a commit to eclipse-glsp/glsp-eclipse-integration that referenced this pull request May 23, 2022
planger added a commit to eclipse-glsp/glsp-eclipse-integration that referenced this pull request May 23, 2022
planger added a commit to eclipse-glsp/glsp-eclipse-integration that referenced this pull request May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to latest log4j 2.x version
4 participants