648: Clean up operation handlers #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-fleck-at
force-pushed
the
issue-648
branch
from
88a8ab3
to
71c4f0b
Compare
- Ensure EMF operation handlers do not inherit from gmodel handlers -- Use generic server handlers and EMFOperation interface as base - Introduce interface for creation (node|edge) operation handler -- Provide utility methods in interface where applicable -- Ensure abstract implementations have 'Abstract' in name -- Provide abstract implementations for EMF case - Refactor some shared functionality into interfaces Fixes eclipse-glsp/glsp#648
martin-fleck-at
force-pushed
the
issue-648
branch
from
71c4f0b
to
d6f953c
Compare
planger
approved these changes
May 10, 2022
|
@planger can you give me a short feedback about what's your opinion regarding the createNode method - see my comments above |
Answered here: eclipse-glsp/glsp#637 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure EMF operation handlers do not inherit from gmodel handlers
-- Use generic server handlers and EMFOperation interface as base
Introduce interface for creation (node|edge) operation handler
-- Provide utility methods in interface where applicable
-- Ensure abstract implementations have 'Abstract' in name
-- Provide abstract implementations for EMF case
Refactor some shared functionality into interfaces
eclipse-glsp/glsp#648