#694: Add Layoutable interface #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Layout Options on children will be useful to configure child-specific layout options (Rather than only be able to configure the parent layout itself). This change also makes the Graph model more consistent with the Sprotty API (Which accepts layout options on SShapeElement) |
|
Test model: This model can't be open on the current It can be open with this PR. Note: layout might be off, as I'm still working on the client layout for eclipse-glsp/glsp#694. The goal of this PR is to make it possible to open/parse the model. |
CamilleLetavernier
force-pushed
the
issues/694-layout
branch
from
ffe92bb
to
d97e52c
Compare
ndoschek
requested changes
Jul 13, 2022
plugins/org.eclipse.glsp.graph/src-gen/org/eclipse/glsp/graph/GLayoutable.java
Outdated
Show resolved
Hide resolved
- Update the Graph model for consistency with the Sprotty API - GShapeElement is a GLayoutable and can have layoutOptions refs eclipse-glsp/glsp#694 Contributed on behalf of STMicroelectronics. Signed-off-by: Camille Letavernier <cletavernier@eclipsesource.com>
CamilleLetavernier
force-pushed
the
issues/694-layout
branch
from
d97e52c
to
4f7cb88
Compare
|
Thanks for the review! I've updated the Genmodel and regenerated the files. I also rebased on master. |
ndoschek
approved these changes
Jul 13, 2022
Merged
ndoschek
added a commit
that referenced
this pull request
Jul 14, 2022
cf. #175 Contributed on behalf of STMicroelectronics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs eclipse-glsp/glsp#694
Contributed on behalf of STMicroelectronics.