Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Jetty 10 #186

Merged
merged 2 commits into from
Jan 23, 2023
Merged

Switch to Jetty 10 #186

merged 2 commits into from
Jan 23, 2023

Conversation

tortmayr
Copy link
Contributor

  • Using Jetty 11 causes unnecessary Version resolution conflicts with the Jetty Version used by Eclipse (10) =>
    Align versions by using Jetty 10 for GLSP instead of 11
  • Remove reexporting of jetty dependencies to avoid potential version conflicts
  • Refactor glsp.graph package to avoid usage of internal API that is no longer exposed with Gson >=2.8.9

Contributed on behalf of STMicroelectronics

@tortmayr tortmayr requested a review from planger January 23, 2023 12:59
@tortmayr
Switch to Jetty 10
ce61994 
- Using Jetty 11 causes unnecessary Version resolution conflicts with the Jetty Version used by Eclipse (10) =>
Align versions by using Jetty 10 for GLSP instead of 11
- Remove reexporting of jetty dependencies to avoid potential version conflicts
- Refactor glsp.graph package to avoid usage of internal API that is no longer exposed with Gson >=2.8.9

Contributed on behalf of STMicroelectronics
@tortmayr tortmayr force-pushed the jetty-followup branch 2 times, most recently from f2f1f3c to ce61994 Compare January 23, 2023 16:40
planger
planger approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good to me and workflow example still works as expected!

@tortmayr tortmayr merged commit 34758e2 into master Jan 23, 2023
@tortmayr tortmayr deleted the jetty-followup branch January 23, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@planger planger planger approved these changes

Assignees
No one assigned
Labels
changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tortmayr @planger