Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't wait on stdin in websocket server #189

Merged
merged 2 commits into from
Jan 26, 2023
Merged

don't wait on stdin in websocket server #189

merged 2 commits into from
Jan 26, 2023

Conversation

mockersf
Copy link
Contributor

closes eclipse-glsp/glsp#883

remove listening on stdin, so that the server can be started without access to stdin and rely on process control to stop

@tortmayr tortmayr self-requested a review January 26, 2023 22:33
tortmayr
tortmayr approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM! It definitely makes sense to not rely on stdin here.

@tortmayr tortmayr merged commit 5198b15 into eclipse-glsp:master Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tortmayr tortmayr tortmayr approved these changes

Assignees
No one assigned
Labels
changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

glsp-server: don't listen on stdin in websocket server
2 participants
@mockersf @tortmayr