Add support for progress reporting #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
tortmayr
approved these changes
Jul 14, 2023
| @@ -57,35 +57,6 @@ public static ServerMessageAction error(final Exception e) { | |||
| return error(getMessage(e), getDetails(e)); | |||
| } | |||
|
|
|||
| public static ServerMessageAction message(final Severity severity, final String message, | |||
| final int timeout) { | |||
There was a problem hiding this comment.
Any specific reason why we remove this entirely instead of just removing the timeout parameter?
There was a problem hiding this comment.
I think because they are already above, if I'm not mistaken?
There was a problem hiding this comment.
Ah makes sense. I didn't look at the full scope of the file 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eclipse-glsp/glsp#1019