GLSP 2.0 - SModelElement Arguments?

[rsoika]

Hi,
before glsp version 2.0 I often used code to get/set args of a SModelElement like this:

import {
    SModelElement,
    hasArguments
} from '@eclipse-glsp/client';
.....

       let element: SModelElement | undefined;
       ....
        if (element && hasArguments(element)) {
              element.args.....
        }

I understand that SModelElement is now replaced by GModelElement, but the method hasArguments is lost?
I did not find any comments about the arguments attribute in the glsp-client release notes.
Is my assumption correct that SModelElement was replaced by GModelElement?

[rsoika]

...ok I try to answer it by myself: it looks like hasArguments is replaced by hasArgs.
So the code should now look like the following - right?

import {
    GModelElement,
    hasArgs
} from '@eclipse-glsp/client';
.....

       let element: GModelElement | undefined;
       ....
        if (element && hasArgs(element)) {
              element.args.....
        }

[tortmayr]

Yes your are correct. We missed this change in the changelog. The feature for adding arbitary arguments has been refactored in 2.0 and is now applied to all model elements per default. In the process the hasArguments function was also renamed to hasArgs. Sorry, we missed to add this change to the changelog.