Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create end-to-end tests for all integrations and features #1154

Closed
planger opened this issue Nov 2, 2023 · 1 comment
Closed

Create end-to-end tests for all integrations and features #1154

planger opened this issue Nov 2, 2023 · 1 comment
Assignees
@haydar-metin
Labels
enhancement New feature or request playwright testing theia vscode
Projects
GLSP kanban

Comments

@planger
Copy link
Member

planger commented Nov 2, 2023

Now as we have a nice Playwright page object library, let's create / run end-to-end tests for all features of the Workflow example on every change of glsp-client, glsp-server, and the integration repos.
The integration code and tests can remain in the glsp-playwright repository.
@planger planger added this to New in GLSP kanban via automation Nov 2, 2023
@planger planger moved this from New to Backlog in GLSP kanban Nov 2, 2023
@tortmayr tortmayr mentioned this issue Nov 30, 2023
Open
@planger planger moved this from Backlog to To do in GLSP kanban Jan 11, 2024
@haydar-metin haydar-metin self-assigned this Jan 12, 2024
@planger planger moved this from To do to In progress in GLSP kanban Jan 25, 2024
tortmayr added a commit to eclipse-glsp/glsp-playwright that referenced this issue Mar 2, 2024
@tortmayr
GLSP-1154 Add actions workflow for playwright testing
363461d 
- Add  workflow for executing playwright tests for a dedicated GLSP component/project
- Adapt playwright config to also report via `github-actions-repoter` when executed in a CI env
- Adapt playwright config to consider the --project argument and only create projects relevant for the test execution. This avoids the need for a fully configured env if only running a certain test set.
Part of eclipse-glsp/glsp#1154
tortmayr added a commit to eclipse-glsp/glsp-playwright that referenced this issue Mar 2, 2024
@tortmayr
GLSP-1154 Add actions workflow for playwright testing
dbe7efd 
- Add  workflow for executing playwright tests for a dedicated GLSP component/project
- Adapt playwright config to also report via `github-actions-repoter` when executed in a CI env
- Adapt playwright config to consider the --project argument and only create projects relevant for the test execution. This avoids the need for a fully configured env if only running a certain test set.
Part of eclipse-glsp/glsp#1154
tortmayr added a commit to eclipse-glsp/glsp-playwright that referenced this issue Mar 3, 2024
@tortmayr
Improve build setup and switch to actions CI setup
1bb8a8d 
# GLSP-1179
- Update tsconfig, eslint config and package.json to fully utilize composite typescript/eslint builds
-- Compile typescript code from root instead of streaming to each package
-- Remove lint and clean from prepare steps. Linting is the most expensive step and is already
    covered via vscode/ci. Manual execution is enough. Skipping the clean step per default
    ensures that we can fully utilize incremental ts builds
-- Adapt linting commands to be executed with a single command from root instead of streaming 
    to all packages
Part of eclipse-glsp/glsp#1179


# GLSP 1154
- Update project configuration to also create projects for testing against firefox/edge
  if the MULTI_BROWSER env variable is set to true
- Update to playwright 1.42.1. This is necessary to allow passing regexes/wildcards for the --project argument
- Also report with `estruyf/github-actions-reporter` when running in CI

Part  of  eclipse-glsp/glsp#1154
tortmayr added a commit to eclipse-glsp/glsp-playwright that referenced this issue Mar 3, 2024
@tortmayr
Improve build setup and switch to actions CI setup
0e48491 
# GLSP-1179
- Update tsconfig, eslint config and package.json to fully utilize composite typescript/eslint builds
-- Compile typescript code from root instead of streaming to each package
-- Remove lint and clean from prepare steps. Linting is the most expensive step and is already
    covered via vscode/ci. Manual execution is enough. Skipping the clean step per default
    ensures that we can fully utilize incremental ts builds
-- Adapt linting commands to be executed with a single command from root instead of streaming 
    to all packages
Part of eclipse-glsp/glsp#1179


# GLSP 1154
- Update project configuration to also create projects for testing against firefox/edge
  if the MULTI_BROWSER env variable is set to true
- Update to playwright 1.42.1. This is necessary to allow passing regexes/wildcards for the --project argument
- Also report with `estruyf/github-actions-reporter` when running in CI

Part  of  eclipse-glsp/glsp#1154
@haydar-metin haydar-metin mentioned this issue Mar 15, 2024
Open
@planger
Copy link
Member Author

planger commented Mar 21, 2024

Will be tracked in #1287

@planger planger closed this as not planned Won't fix, can't repro, duplicate, stale Mar 21, 2024
GLSP kanban automation moved this from In progress to Done Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haydar-metin haydar-metin

Labels
enhancement New feature or request playwright testing theia vscode
Projects
No open projects
GLSP kanban
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@planger @haydar-metin