Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase GLSPDiagramManager open priority #24

Closed
eneufeld opened this issue Feb 2, 2020 · 2 comments · Fixed by eclipse-glsp/glsp-theia-integration#26
Closed

Increase GLSPDiagramManager open priority #24

eneufeld opened this issue Feb 2, 2020 · 2 comments · Fixed by eclipse-glsp/glsp-theia-integration#26
Assignees
@eneufeld
Labels
client theia
Projects
GLSP kanban

Comments

@eneufeld
Copy link
Contributor

eneufeld commented Feb 2, 2020

The GLSPDiagramManager must increase its priority because it is otherwise overwritten by eg @theia/editor-preview. I suggest to use a value of 1000 or higher.
@tortmayr
Copy link
Contributor

tortmayr commented Feb 7, 2020

What exactly is the purpose of @theia/editor-preview? To me this sounds like some sort of preview/read only functionality. If so wouldn't it be better to check if we could make the GLSP editor compatible with this preview editor instead of overwriting it?

@eneufeld
Copy link
Contributor Author

eneufeld commented Feb 7, 2020

Based on the description here it looks like the editor VS Code has that closes automatically if you open a new file. So it is a temporary view of a file that you do not modify.
In this case it would make sense to integrate GLSP there, too.

@tortmayr tortmayr transferred this issue from eclipse-glsp/glsp-client Feb 13, 2020
@tortmayr tortmayr added this to Backlog in GLSP kanban Feb 13, 2020
@planger planger moved this from Backlog to To do in GLSP kanban Feb 13, 2020
eneufeld added a commit to eneufeld/glsp-theia-integration that referenced this issue Mar 12, 2020
@eneufeld
Increase handle priority of GLSPDiagramManager
ac516da 
Increase the return priority to counteract:
https://github.com/eclipse-theia/theia/blob/07d01332d564b60d051229a8fe323853fb2bc68e/packages/editor-preview/src/browser/editor-preview-manager.ts#L106

Fixes eclipse-glsp/glsp#24

Signed-off-by: Eugen Neufeld <eneufeld@eclipsesource.com>
@eneufeld eneufeld mentioned this issue Mar 12, 2020
Merged
@planger planger mentioned this issue Mar 12, 2020
Open
GLSP kanban automation moved this from To do to Done Mar 12, 2020
planger pushed a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Mar 12, 2020
@eneufeld @planger
Increase handle priority of GLSPDiagramManager
da2db37 
Increase the return priority to counteract:
https://github.com/eclipse-theia/theia/blob/07d01332d564b60d051229a8fe323853fb2bc68e/packages/editor-preview/src/browser/editor-preview-manager.ts#L106

Fixes eclipse-glsp/glsp#24

Signed-off-by: Eugen Neufeld <eneufeld@eclipsesource.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eneufeld eneufeld

Labels
client theia
Projects
No open projects
GLSP kanban
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Increase handle priority of GLSPDiagramManager eneufeld/glsp-theia-integration
2 participants
@eneufeld @tortmayr