Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minimal example] Does the structure /client /sever make sense? #388

Closed
JonasHelming opened this issue Sep 14, 2021 · 1 comment
Closed
Assignees

Comments

@JonasHelming
Copy link

From: eclipse-theia/generator-theia-extension#111
The idea of client and server (top level directories) does not make sense to me, can you clarify why it's done this way? The "client" component (theia) is made up of client + server already so it may be confusing to adopters.

@planger
Copy link
Member

planger commented Oct 7, 2021

Hm, yeah I see your point. The terms client and server are here meant with respect to GLSP -- in the context of GLSP Theia is a GLSP client that talks to the GLSP server. Maybe we should rename those folders to glsp-server (from server) and glsp-client (from client).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants