Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert CLI package back to commonjs #1335

Merged
merged 3 commits into from
May 13, 2024
Merged

Convert CLI package back to commonjs #1335

merged 3 commits into from
May 13, 2024

Conversation

tortmayr
Copy link
Contributor

What it does

Convert CLI package back to commonjs
Convert the CLI package back to commonjs as the esm module caused issues in downstream projects.
Use async imports to still be able to use globby.

Also fix copyright header violations

How to test

Follow-ups

Changelog

  • This PR should be mentioned in the changelog
  • This PR introduces a breaking change (if yes, provide more details below for the changelog and the migration guide)

Convert the CLI package back to commonjs as the esm module caused issues in downstream projects.
Use async imports to still be able to use globby.
@tortmayr tortmayr changed the title Generate index fu Convert CLI package back to commonjs May 13, 2024
Copy link
Contributor

@martin-fleck-at martin-fleck-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tortmayr tortmayr merged commit c32aadb into master May 13, 2024
5 checks passed
@tortmayr tortmayr deleted the generate-index-fu branch June 22, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants