Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend HTTP protocol adapter to support commands and their responses. #618

Closed
sysexcontrol opened this issue May 15, 2018 · 1 comment
Closed

Extend HTTP protocol adapter to support commands and their responses. #618

sysexcontrol opened this issue May 15, 2018 · 1 comment
Assignees
@sysexcontrol
Labels
enhancement HTTP Adapter
Projects
0.6
Milestone
0.6

Comments

@sysexcontrol
Copy link
Contributor

The HTTP protocol adapter needs to treat commands from an application and must be extended for this purpose.

TODOs (maybe not complete yet):

  • define headers that identify a command and are sent to a device (to enable it for sending responses)
  • delay responses by using the ttd value (that is available as header already)
  • put a command to the body of the response
  • describe the new HTTP features and how they enable command and control for a HTTP device
  • define an event specifically for sending a response from the device to the application that has sent the command (maybe piggy backing other messages is sufficient for empty command responses that do not need the payload to contain the response)
sysexcontrol added a commit that referenced this issue May 15, 2018
@sysexcontrol
[#618] Define reply and correlation id headers for command responses.
45d4ba5 
Signed-off-by: Karsten Frank <Karsten.Frank@bosch-si.com>
@sysexcontrol sysexcontrol self-assigned this May 16, 2018
sysexcontrol added a commit that referenced this issue May 18, 2018
@sysexcontrol
[#618] Utility to combine reply-to and correlation-id.
cf30294 
This commit provides only the utility methods to transport the two parts as
one String (that can serve as a request-id). In followup messages
this String can be split into the original ones again by invoking the
inverse utility method.

Signed-off-by: Karsten Frank <Karsten.Frank@bosch-si.com>
sysexcontrol added a commit to bosch-io/hono that referenced this issue May 18, 2018
@sysexcontrol
[eclipse-hono#618] HTTP protocol adapter supports command and control.
fa8060f 
Besides supporting downstream messages, the HTTP protocol
adapter now supports to receive a command from an application
if a downstream message indicates that it stays connected
by using the `hono-ttd` parameter.
A command is sent to the device in the response payload of
the request with a `hono-cmd-req-id' parameter.

Signed-off-by: Karsten Frank <Karsten.Frank@bosch-si.com>
sysexcontrol added a commit to bosch-io/hono that referenced this issue May 18, 2018
@sysexcontrol
[eclipse-hono#618] Consumer Application tries to send a command when …
3d21137 
…notified.

Currently, there are only 'void' command supported and only the
HTTP adapter supports to receive a command.

Signed-off-by: Karsten Frank <Karsten.Frank@bosch-si.com>
sysexcontrol added a commit to bosch-io/hono that referenced this issue May 22, 2018
@sysexcontrol
[eclipse-hono#618] Improvements from review comments.
c9faf4e 
Signed-off-by: Karsten Frank <Karsten.Frank@bosch-si.com>
sysexcontrol added a commit to bosch-io/hono that referenced this issue May 22, 2018
@sysexcontrol
[eclipse-hono#618] Received commands are always responded with status…
1521e17 
… 200 to app.

To achieve a successful command pattern inside the application, the
HTTP PA answers a received command by replying to the application with a
status 200. Although a real answer from the device is not yet implemented,
this follows the future implementation of expecting a response from the
device already.

Signed-off-by: Karsten Frank <Karsten.Frank@bosch-si.com>
sysexcontrol added a commit to bosch-io/hono that referenced this issue May 22, 2018
@sysexcontrol
[eclipse-hono#618] Removed unused import.
a0c45f8 
Signed-off-by: Karsten Frank <Karsten.Frank@bosch-si.com>
sysexcontrol added a commit to bosch-io/hono that referenced this issue May 22, 2018
@sysexcontrol
[eclipse-hono#618] Use null Buffer for (fake) response to application.
3c4af5f 
Signed-off-by: Karsten Frank <Karsten.Frank@bosch-si.com>
sysexcontrol added a commit to bosch-io/hono that referenced this issue May 22, 2018
@sysexcontrol
[eclipse-hono#618] Received commands are always responded with status…
8300ffa 
… 200 to app.

To achieve a successful command pattern inside the application, the
HTTP PA answers a received command by replying to the application with a
status 200. Although a real answer from the device is not yet implemented,
this follows the future implementation of expecting a response from the
device already.

Signed-off-by: Karsten Frank <Karsten.Frank@bosch-si.com>
sysexcontrol added a commit that referenced this issue May 22, 2018
@sysexcontrol
[#618] HTTP protocol adapter supports command and control.
e75f88c 
Besides supporting downstream messages, the HTTP protocol
adapter now supports to receive a command from an application
if a downstream message indicates that it stays connected
by using the `hono-ttd` parameter.
A command is sent to the device in the response payload of
the request with a `hono-cmd-req-id' parameter.

Signed-off-by: Karsten Frank <Karsten.Frank@bosch-si.com>
sysexcontrol added a commit that referenced this issue May 22, 2018
@sysexcontrol
[#618] Consumer Application tries to send a command when notified.
515b587 
Currently, there are only 'void' command supported and only the
HTTP adapter supports to receive a command.

Signed-off-by: Karsten Frank <Karsten.Frank@bosch-si.com>
sysexcontrol added a commit that referenced this issue May 22, 2018
@sysexcontrol
[#618] Improvements from review comments.
c14bbbc 
Signed-off-by: Karsten Frank <Karsten.Frank@bosch-si.com>
sysexcontrol added a commit that referenced this issue May 22, 2018
@sysexcontrol
[#618] Received commands are always responded with status 200 to app.
a844f79 
To achieve a successful command pattern inside the application, the
HTTP PA answers a received command by replying to the application with a
status 200. Although a real answer from the device is not yet implemented,
this follows the future implementation of expecting a response from the
device already.

Signed-off-by: Karsten Frank <Karsten.Frank@bosch-si.com>
sysexcontrol added a commit to bosch-io/hono that referenced this issue May 22, 2018
@sysexcontrol
[eclipse-hono#618] Describe callback for sending commands in example …
d7b6405 
…application.

Signed-off-by: Karsten Frank <Karsten.Frank@bosch-si.com>
sysexcontrol added a commit to bosch-io/hono that referenced this issue May 22, 2018
@sysexcontrol
[eclipse-hono#618] Walkthrough for command and control by using the e…
731dc22 
…xample app.

Signed-off-by: Karsten Frank <Karsten.Frank@bosch-si.com>
sysexcontrol added a commit to bosch-io/hono that referenced this issue May 22, 2018
@sysexcontrol
[eclipse-hono#618] Adopted to review comments.
9ccd09c 
Signed-off-by: Karsten Frank <Karsten.Frank@bosch-si.com>
sysexcontrol added a commit to bosch-io/hono that referenced this issue May 23, 2018
@sysexcontrol
[eclipse-hono#618] Describe callback for sending commands in example …
10b31d9 
…application.

Signed-off-by: Karsten Frank <Karsten.Frank@bosch-si.com>
sysexcontrol added a commit to bosch-io/hono that referenced this issue May 23, 2018
@sysexcontrol
[eclipse-hono#618] Walkthrough for command and control by using the e…
ff146b2 
…xample app.

Signed-off-by: Karsten Frank <Karsten.Frank@bosch-si.com>
sysexcontrol added a commit that referenced this issue May 23, 2018
@sysexcontrol
[#618] Describe callback for sending commands in example application.
3098156 
Signed-off-by: Karsten Frank <Karsten.Frank@bosch-si.com>
sysexcontrol added a commit that referenced this issue May 23, 2018
@sysexcontrol
[#618] Walkthrough for command and control by using the example app.
80a9d08 
Signed-off-by: Karsten Frank <Karsten.Frank@bosch-si.com>
sysexcontrol added a commit that referenced this issue May 23, 2018
@sysexcontrol
[#618] Add hint to synchronize clocks for container machines.
1f9f421 
Without ensuring correct clocks, the command and control example may not
work correctly since timestamps may be considered expired already.

Signed-off-by: Karsten Frank <Karsten.Frank@bosch-si.com>
@sophokles73 sophokles73 added this to To do in 0.6 via automation May 24, 2018
@sophokles73 sophokles73 added this to the 0.6 milestone May 24, 2018
@sysexcontrol
Copy link
Contributor Author

Fixed by the referencing commits.

0.6 automation moved this from To do to Done May 24, 2018
sysexcontrol added a commit that referenced this issue May 24, 2018
@sysexcontrol
[#618] Close the command sender after command was sent from application.
2426dbc 
Signed-off-by: Karsten Frank <Karsten.Frank@bosch-si.com>
sophokles73 pushed a commit that referenced this issue Aug 6, 2018
[#618] Fix method and parameter naming.
096586e 
Signed-off-by: Kai Hudalla <kai.hudalla@bosch-si.com>
sophokles73 pushed a commit that referenced this issue Aug 6, 2018
[#618] Adapt CORS handling to support command & control.
6430b99 
The telemetry and event endpoints now include the TTD header in the list
of allowed headers in response to a CORS preflight request.

The control endpoint now includes the (required) "hono-cmd-status"
header in the list of allowed headers in response to a
CORS preflight request.

Signed-off-by: Kai Hudalla <kai.hudalla@bosch-si.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sysexcontrol sysexcontrol

Labels
enhancement HTTP Adapter
Projects
No open projects
0.6
  
Done
Milestone
0.6
Development

No branches or pull requests
2 participants
@sophokles73 @sysexcontrol