Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement reconnect receiver link in HTTP adapter #629

Closed
sysexcontrol opened this issue May 28, 2018 · 1 comment
Closed

Implement reconnect receiver link in HTTP adapter #629

sysexcontrol opened this issue May 28, 2018 · 1 comment
Assignees
@sysexcontrol
Labels
C&C Command and Control HTTP Adapter
Projects
0.7-M1
Milestone
0.7

Comments

@sysexcontrol
Copy link
Contributor

The HTTP adapter should reopen the receiver link for Command and Control if the AMQP network closes the connection/link.
Currently the link is only closed after a command was received or the ttd expired.
@sysexcontrol sysexcontrol added HTTP Adapter C&C Command and Control labels May 28, 2018
@sysexcontrol sysexcontrol added this to To do in 0.7-M1 via automation May 28, 2018
@sysexcontrol sysexcontrol self-assigned this May 29, 2018
@sophokles73 sophokles73 added this to the 0.7 milestone May 30, 2018
sysexcontrol added a commit that referenced this issue Jun 7, 2018
@sysexcontrol
[#629] Recreate command receiver link if it was closed.
794eb68 
The receiver link is tried to be opened again after a timeout of 1 second if it
was closed from the AMQP 1.0 network.

Signed-off-by: Karsten Frank <Karsten.Frank@bosch-si.com>
sysexcontrol added a commit that referenced this issue Jun 7, 2018
@sysexcontrol
[#629] Provide unit tests for the command receiver link.
a0139fe 
Additionally, tests are added that verify a message is sent downstream
if all preconditions are fulfilled.

Signed-off-by: Karsten Frank <Karsten.Frank@bosch-si.com>
@sysexcontrol
Copy link
Contributor Author

Fixed by 794eb68 and a0139fe.

0.7-M1 automation moved this from To do to Done Jun 7, 2018
sysexcontrol added a commit that referenced this issue Jun 8, 2018
@sysexcontrol
[#629] Increase timeout for specific http adapter unit tests.
7f8ba45 
Signed-off-by: Karsten Frank <Karsten.Frank@bosch-si.com>
sysexcontrol added a commit that referenced this issue Jun 11, 2018
@sysexcontrol
[#629] Attempt to stabilize nightly build by increasing test timeout.
bd6002a 
The Hono nightly build currently fails for new http adapter tests cases
after 10 seconds per test - with this commit it is attempted if it can
be fixed by increasing it to 20 seconds. In local environments these tests
usually succeed.

Signed-off-by: Karsten Frank <Karsten.Frank@bosch-si.com>
sysexcontrol added a commit that referenced this issue Jun 12, 2018
@sysexcontrol
[#629] Correct error handling if command consumer cannot be setup.
5e15e3a 
Signed-off-by: Karsten Frank <Karsten.Frank@bosch-si.com>
sophokles73 pushed a commit that referenced this issue Jun 12, 2018
[#629] Remove obsolete test case.
267a0f3 
Signed-off-by: Kai Hudalla <kai.hudalla@bosch-si.com>
sophokles73 pushed a commit that referenced this issue Jun 12, 2018
[#629] Use common fixture.
068f0e9 
Signed-off-by: Kai Hudalla <kai.hudalla@bosch-si.com>
sysexcontrol added a commit that referenced this issue Jun 12, 2018
@sysexcontrol
[#629] Closed command links are only logged and not reopened anymore.
1f1dd5a 
Other strategies can be implemented by overwriting the provided method
in subclasses.

Signed-off-by: Karsten Frank <Karsten.Frank@bosch-si.com>
sophokles73 pushed a commit that referenced this issue Jun 12, 2018
[#629] Use shared HTTP client.
0956e41 
Signed-off-by: Kai Hudalla <kai.hudalla@bosch-si.com>
sophokles73 pushed a commit that referenced this issue Jun 12, 2018
[#629] Enable trace logging for test execution.
917c13a 
Signed-off-by: Kai Hudalla <kai.hudalla@bosch-si.com>
sophokles73 pushed a commit that referenced this issue Jun 12, 2018
[#629] Enable additional trace logging for test execution.
3924ad9 
Signed-off-by: Kai Hudalla <kai.hudalla@bosch-si.com>
sophokles73 pushed a commit that referenced this issue Jun 12, 2018
[#629] Increase log level for test execution back to INFO.
6464d00 
Signed-off-by: Kai Hudalla <kai.hudalla@bosch-si.com>
sysexcontrol added a commit that referenced this issue Jun 13, 2018
@sysexcontrol
[#629] Remove unused constant for obsolete command link reopening.
6e2fac0 
Signed-off-by: Karsten Frank <Karsten.Frank@bosch-si.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sysexcontrol sysexcontrol

Labels
C&C Command and Control HTTP Adapter
Projects
No open projects
0.7-M1
  
Done
Milestone
0.7
Development

No branches or pull requests
2 participants
@sophokles73 @sysexcontrol