Add ApplicationClient addOnClientReadyHandler(), fix example application startup #3278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophokles73
reviewed
Jun 3, 2022
clients/amqp-common/src/main/java/org/eclipse/hono/client/amqp/AbstractServiceClient.java
Outdated
Show resolved
Hide resolved
| @@ -102,6 +103,11 @@ public KafkaApplicationClientImpl( | |||
| this.consumerConfig = consumerConfig; | |||
| } | |||
|
|
|||
| @Override | |||
| public void addOnClientReadyHandler(final Handler<AsyncResult<Void>> handler) { | |||
There was a problem hiding this comment.
is this method being used anywhere?
There was a problem hiding this comment.
Not in Hono itself. But it is useful for applications using the Hono (Kafka)ApplicationClient.
|
@calohmn Are you still working on this? Do you want/need this in 2.0.0? |
|
@sophokles73 I'm still on it, yes. But I think this should be merged after the 2.0.0 release. |
|
@calohmn is this ready to be merged? |
|
@sophokles73 Not yet. |
calohmn
force-pushed
the
PR/applicationclient_readyhandler
branch
from
f9ba003
to
fecf257
Compare
|
I've added the |
sophokles73
reviewed
Sep 26, 2022
...mqp/src/main/java/org/eclipse/hono/application/client/amqp/ProtonBasedApplicationClient.java
Show resolved
Hide resolved
...mqp/src/main/java/org/eclipse/hono/application/client/amqp/ProtonBasedApplicationClient.java
Show resolved
Hide resolved
Also improve AbstractServiceClient start/stop extensibility. Signed-off-by: Carsten Lohmann <carsten.lohmann@bosch.io>
Signed-off-by: Carsten Lohmann <carsten.lohmann@bosch.io>
calohmn
force-pushed
the
PR/applicationclient_readyhandler
branch
from
fecf257
to
aa10a03
Compare
calohmn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is especially needed for theKafkaApplicationClient, letting a given handler be invoked when the Kafka produceris ready.
Also introduce a lifecycleStatus in
AbstractServiceClient, preventing successive start() invocations.Adding
addOnClientReadyHandler()inApplicationClientandProtonBasedApplicationClient.(
KafkaApplicationClientchange already done in #3282.)Also fixing application client startup in Hono example application.