[#3446] support the things stack V3 uplink #3447
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobClaerhout
requested review from
kaniyan,
sophokles73 and
calohmn
as code owners
BobClaerhout
force-pushed
the
3446
branch
2 times, most recently
from
cb49368
to
5e609d6
Compare
Signed-off-by: Bob Claerhout <claerhout.bob@gmail.com>
sophokles73
reviewed
Nov 23, 2022
| @@ -34,6 +34,10 @@ | |||
|
|
|||
| /** | |||
| * A LoRaWAN provider with API for Things Network. | |||
| * <p> | |||
| * This provider supports messages that comply with the | |||
| * <a href="https://www.thethingsnetwork.org/docs/applications/http/#uplink"> | |||
There was a problem hiding this comment.
Tthis seems to point to the same URL as the one in the JavaDoc of TheThingsStackProvider class.
Does this mean that both providers are basically the same?
| } | ||
| }, | ||
| "simulated": true | ||
| } |
There was a problem hiding this comment.
please add an empty line at the end
|
Closing this MR. I indeed realized TTN and TTS are the same. So no need for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bob Claerhout claerhout.bob@gmail.com