Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the iceoryx submodule #7

Closed
elBoberido opened this issue Sep 16, 2021 · 0 comments · Fixed by #11
Closed

Remove the iceoryx submodule #7

elBoberido opened this issue Sep 16, 2021 · 0 comments · Fixed by #11
Assignees
@elBoberido
Labels
tooling

Comments

@elBoberido
Copy link
Member

Currently iceoryx is a submodule in iceoryx-rs. It would be better to let build.rs clone the repo before building it. This would prevent issues when user clone iceoryx-rs without the --recursive flag
@elBoberido elBoberido mentioned this issue Sep 16, 2021
Open
@elBoberido elBoberido changed the title Remove the iceoryx submodlue Remove the iceoryx submodule Sep 16, 2021
@elBoberido elBoberido self-assigned this Sep 16, 2021
elBoberido added a commit that referenced this issue Sep 16, 2021
@elBoberido
iox-#7 Remove iceoryx submodule
5bfd593
@elBoberido elBoberido linked a pull request Sep 16, 2021 that will close this issue
iox-#7 Remove iceoryx submodule #11
Merged
elBoberido added a commit that referenced this issue Sep 17, 2021
@elBoberido
iox-#7 Remove iceoryx submodule
6f5b274
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elBoberido elBoberido

Labels
tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

iox-#7 Remove iceoryx submodule eclipse-iceoryx/iceoryx-rs
1 participant
@elBoberido