Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iox 1 use maybe uninit for sample #34

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Iox 1 use maybe uninit for sample #34

merged 1 commit into from
Jun 28, 2022

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Jun 28, 2022 •
edited
Loading

Pre-Review Checklist for the PR Author

  1. Code follows the Rust coding style and is formatted with rustfmt
  2. Branch follows the naming format (iox-123-this-is-a-branch)
  3. Commits messages are according to this guideline
  4. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  5. Relevant issues are linked
  6. Add sensible notes for the reviewer
  7. All checks have passed (except task-list-completed)
  8. Assign PR to reviewer

Notes for Reviewer

This PR enforces that a SampleMut<T> is always initialized by adding Default as trait bound for T. In case this restriction is not desired, a new API call for SampleMut<MaybeUninit<T>> is added.

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido added enhancement New feature or request refactoring labels Jun 28, 2022
@elBoberido elBoberido self-assigned this Jun 28, 2022
@elBoberido elBoberido force-pushed the iox-1-use-maybe-uninit-for-sample branch from 8b5580a to d2fb984 Compare June 28, 2022 08:06
@elBoberido elBoberido force-pushed the iox-1-use-maybe-uninit-for-sample branch from d2fb984 to bdbd761 Compare June 28, 2022 11:09
@elBoberido elBoberido merged commit 9b2a952 into master Jun 28, 2022
@elBoberido elBoberido deleted the iox-1-use-maybe-uninit-for-sample branch June 28, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elfenpiff elfenpiff elfenpiff approved these changes

Assignees

@elBoberido elBoberido

Labels
enhancement New feature or request refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use MaybeUninit for newly allocated samples
2 participants
@elBoberido @elfenpiff