Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#4 Update readme for initial release #45

Merged
merged 2 commits into from
Jun 30, 2022

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Jun 30, 2022

Pre-Review Checklist for the PR Author

  1. Code follows the Rust coding style and is formatted with rustfmt
  2. Branch follows the naming format (iox-123-this-is-a-branch)
  3. Commits messages are according to this guideline
  4. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  5. Relevant issues are linked
  6. Add sensible notes for the reviewer
  7. All checks have passed (except task-list-completed)
  8. Assign PR to reviewer

Notes for Reviewer

More content for the readme.

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido self-assigned this Jun 30, 2022
@elBoberido elBoberido added the documentation Improvements or additions to documentation label Jun 30, 2022
Cargo.toml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated
## About

Eclipse iceoryx is a true zero-copy, inter-process communication framework with the goal to boost
autonomous driving with their demand on high data throughput and low latency. With this properties,
Copy link

@elfenpiff elfenpiff Jun 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I heard the suggestion lately to not state this or mentioned earlier or phrases like that. One should really name the things again.

With this in mind you could also write With iceoryx's bandwidth and speed, is also fits ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I used With its bandwidth and speed, iceoryx also fits ...

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@elBoberido elBoberido merged commit 60f8de1 into master Jun 30, 2022
@elBoberido elBoberido deleted the iox-4-update-readme-for-initial-release branch June 30, 2022 20:01
To build the examples run
### Run the simple publisher and subscriber example

A good introductory example to demonstrate the inter-process communication are `publisher_simple`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked @FerdinandSpitzschnueffler for advise. The statement was: it sounds wrong and has to be completely rewritten. You speak of one (singular) good example and mix it with are (plural).

What about:
The executables publisher_simple and subscriber_simple are forming of a good introductory example.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, they are two examples that work together. How about The 'publisher_simple' and 'subscriber_simple' examples are forming a good inter-process communication demonstration.?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants