Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iox 4 document public api #59

Merged
merged 1 commit into from
Jul 24, 2022
Merged

Iox 4 document public api #59

merged 1 commit into from
Jul 24, 2022

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Jul 22, 2022

Pre-Review Checklist for the PR Author

  1. Code follows the Rust coding style and is formatted with rustfmt
  2. Branch follows the naming format (iox-123-this-is-a-branch)
  3. Commits messages are according to this guideline
  4. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  5. Relevant issues are linked
  6. Add sensible notes for the reviewer
  7. All checks have passed (except task-list-completed)
  8. Assign PR to reviewer

Notes for Reviewer

This is based on #36 which needs to be merged first.

All the public API should now be documented and the documentation is enforced for writing new public API.

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2022

Codecov Report

Merging #59 (42c10cd) into master (ff36d1e) will increase coverage by 0.17%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   55.02%   55.20%   +0.17%     
==========================================
  Files          20       20              
  Lines         945      942       -3     
==========================================
  Hits          520      520              
+ Misses        425      422       -3     
Impacted Files Coverage Δ
iceoryx-sys/src/runtime.rs 100.00% <ø> (ø)
src/error.rs 0.00% <ø> (ø)
src/introspection/memory.rs 0.00% <ø> (ø)
src/introspection/port.rs 0.00% <ø> (ø)
src/introspection/process.rs 0.00% <ø> (ø)
src/lib.rs 100.00% <ø> (ø)
src/publisher.rs 62.75% <0.00%> (ø)
src/sample.rs 59.40% <ø> (ø)
src/sample_mut.rs 70.00% <ø> (ø)
src/subscriber.rs 48.57% <25.00%> (+1.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff36d1e...42c10cd. Read the comment docs.

@elBoberido elBoberido changed the base branch from master to iox-36-untyped-API July 22, 2022 18:32
@elBoberido elBoberido marked this pull request as ready for review July 22, 2022 18:35
Base automatically changed from iox-36-untyped-API to master July 24, 2022 19:37
@elBoberido elBoberido merged commit 68fbd03 into master Jul 24, 2022
@elBoberido elBoberido deleted the iox-4-document-public-API branch July 24, 2022 19:49
@elBoberido elBoberido self-assigned this Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create documentation
2 participants