Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace occurence of std::list by cxx::list #221

Closed
bishibashiB opened this issue Aug 4, 2020 · 0 comments · Fixed by #224
Closed

Replace occurence of std::list by cxx::list #221

bishibashiB opened this issue Aug 4, 2020 · 0 comments · Fixed by #224
Assignees
Labels
refactoring Refactor code without adding features

Comments

@bishibashiB
Copy link
Contributor

bishibashiB commented Aug 4, 2020

Brief feature description

After finishing cxx::list and cxx::forward_list implementation with #186 the replacement of std::list is consequently the next step.

Detailed information

After replacement of std::list additional replacements might make (1)sense performance-wise or (2)for the sake of a tidy code architecture.
However, for these 'additional replacements' a discussion / agreement should take place before any code rework.
Feel free to put your opinions and hints here.
E.g. so far I can think of discussing

  • RouDi (a)processes and (b)runnables mangement, in app and (c)in introspection => review and establish a picture where to utilize lists, where vectors
  • Could a cxx::list replace the UsedChunkList? Would that justify a rework of code (different member function signature), would concurrency requirements not allow to do so?
  • PortPool 'lists' which use cxx::vector aka FixedPositionContainer (sender/receiver/interface/applicationPortDataList, runnableDataList)
  • PortIntrospection FixedSizeContainer
@mossmaurice mossmaurice added the refactoring Refactor code without adding features label Aug 4, 2020
bishibashiB added a commit to bishibashiB/iceoryx that referenced this issue Aug 7, 2020
…pool FixedPositionContainer to cxx::list

Signed-off-by: Eickhoff Bernhard (CC-AD/ESW1) <bernhard.eickhoff@de.bosch.com>
bishibashiB added a commit to bishibashiB/iceoryx that referenced this issue Aug 14, 2020
…o range-based-loops when removing list elements in loop)

Signed-off-by: Eickhoff Bernhard (CC-AD/ESW1) <bernhard.eickhoff@de.bosch.com>
bishibashiB added a commit to bishibashiB/iceoryx that referenced this issue Aug 24, 2020
…lement references, limit lambda variable capturing to needed scope

Signed-off-by: Eickhoff Bernhard (CC-AD/ESW1) <bernhard.eickhoff@de.bosch.com>
bishibashiB added a commit to bishibashiB/iceoryx that referenced this issue Sep 21, 2020
…ortPool

Signed-off-by: Eickhoff Bernhard (CC-AD/ESW1) <bernhard.eickhoff@de.bosch.com>
bishibashiB added a commit to bishibashiB/iceoryx that referenced this issue Sep 25, 2020
…e cxx::vector

Signed-off-by: Eickhoff Bernhard (CC-AD/ESW1) <bernhard.eickhoff@de.bosch.com>
bishibashiB added a commit to bishibashiB/iceoryx that referenced this issue Nov 24, 2020
Signed-off-by: Eickhoff Bernhard (CC-AD/ESW1) <bernhard.eickhoff@de.bosch.com>
elfenpiff added a commit that referenced this issue Nov 25, 2020
prasannabhat pushed a commit to prasannabhat/iceoryx that referenced this issue Nov 30, 2020
Signed-off-by: Eickhoff Bernhard (CC-AD/ESW1) <bernhard.eickhoff@de.bosch.com>
prasannabhat pushed a commit to prasannabhat/iceoryx that referenced this issue Nov 30, 2020
Signed-off-by: Eickhoff Bernhard (CC-AD/ESW1) <bernhard.eickhoff@de.bosch.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactor code without adding features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants