Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listener examples need to take all samples in the callback #2251

Closed
elBoberido opened this issue Apr 13, 2024 · 1 comment · Fixed by #2252
Closed

Listener examples need to take all samples in the callback #2251

elBoberido opened this issue Apr 13, 2024 · 1 comment · Fixed by #2252
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects

Comments

@elBoberido
Copy link
Member

elBoberido commented Apr 13, 2024

Required information

The listener examples need to show that one needs to take all the samples of a subscriber, else there will be the illusion that samples are lost.

This can happen when a publisher produces more than one sample while the listener callback is executed. If the next callback execution then takes only one sample, the queue starts to pile up until eventually an overflow happens or the producer is blocked.

The examples need to show the correct usage of the listener.

See also #1541 (comment)

@elBoberido
Copy link
Member Author

@mossmaurice can you check whether the discovery example also needs changes?

@elBoberido elBoberido self-assigned this Apr 13, 2024
@elBoberido elBoberido added the documentation Improvements or additions to documentation label Apr 13, 2024
@elBoberido elBoberido added this to To do in v3.0 via automation Apr 13, 2024
@elBoberido elBoberido moved this from To do to In progress in v3.0 Apr 13, 2024
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Apr 13, 2024
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Apr 13, 2024
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Apr 13, 2024
@elBoberido elBoberido added the bug Something isn't working label Apr 13, 2024
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Apr 14, 2024
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Apr 14, 2024
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Apr 14, 2024
elBoberido added a commit to elBoberido/iceoryx that referenced this issue Apr 14, 2024
elBoberido added a commit that referenced this issue Apr 15, 2024
v3.0 automation moved this from In progress to Done Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
v3.0
Done
Development

Successfully merging a pull request may close this issue.

1 participant