Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up std::terminate usage #261

Closed
3 tasks done
mossmaurice opened this issue Aug 26, 2020 · 0 comments · Fixed by #750
Closed
3 tasks done

Clean-up std::terminate usage #261

mossmaurice opened this issue Aug 26, 2020 · 0 comments · Fixed by #750
Assignees
@mossmaurice
Labels
refactoring Refactor code without adding features
Projects
v2.x Sprints
Milestone
Medium prio

Comments

@mossmaurice
Copy link
Contributor

mossmaurice commented Aug 26, 2020 •
edited by budrus
Loading

Brief feature description

Iceoryx often uses std::terminate() instead of errorHandler(). With #130 a clear error handling will be available, afterwards all occurrences should be replaced by calls to the errorHandler.

Detailed information

  • Calling std::terminate is only allowed in building blocks like the errorHandler
  • Replace std::terminate in iceoryx_utils with cxx::Expects, where dependencies shall be avoided to higher level modules
  • Replace std::terminate in iceoryx_posh with cxx::Expects
@mossmaurice mossmaurice self-assigned this Aug 26, 2020
@mossmaurice mossmaurice added the refactoring Refactor code without adding features label Aug 26, 2020
@mossmaurice mossmaurice added this to the v1.x milestone Nov 4, 2020
@mossmaurice mossmaurice mentioned this issue Nov 20, 2020
Merged
19 tasks
@mossmaurice mossmaurice mentioned this issue Dec 14, 2020
Merged
19 tasks
@mossmaurice mossmaurice mentioned this issue Feb 17, 2021
Merged
19 tasks
@mossmaurice mossmaurice added this to To do in v2.x via automation Apr 14, 2021
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Apr 19, 2021
@mossmaurice
iox-eclipse-iceoryx#261 Start replacing std::terminate in iceoryx_utils
fc563ae 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
@mossmaurice mossmaurice added this to To do in Sprints via automation Apr 20, 2021
@mossmaurice mossmaurice moved this from To do to In progress in Sprints Apr 20, 2021
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Apr 21, 2021
@mossmaurice
iox-eclipse-iceoryx#261 Replace std::terminate with Expects in iceory…
220b8d2 
…x_utils

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Apr 21, 2021
@mossmaurice
iox-eclipse-iceoryx#261 Solve ambiguity regarding dev meetup
5054d7d 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Apr 21, 2021
@mossmaurice
iox-eclipse-iceoryx#261 Replace std::terminate with errorHandler in i…
22f1543 
…ceoryx_posh

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Apr 21, 2021
@mossmaurice
iox-eclipse-iceoryx#261 Fix tests
198b206 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Apr 21, 2021
@mossmaurice
iox-eclipse-iceoryx#261 Rework one PoshRuntime unit test, revert Allo…
6b3144b 
…cator changes and move makeScopedStatic to inl

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
@mossmaurice mossmaurice mentioned this issue Apr 21, 2021
Merged
19 tasks
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Apr 22, 2021
@mossmaurice
iox-eclipse-iceoryx#261 Add todo to ProcessManager::ProcessManager
f7d21c9 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Apr 22, 2021
@mossmaurice
iox-eclipse-iceoryx#261 Rename scoped static and create new error enu…
c75ec61 
…m entry

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Apr 22, 2021
@mossmaurice
iox-eclipse-iceoryx#261 Replace isInvalidElement() with direct Expect…
955130e 
…s calls

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Apr 22, 2021
@mossmaurice
iox-eclipse-iceoryx#261 Add doxygen hint to function_ref
d3934c4 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Apr 22, 2021
@mossmaurice
iox-eclipse-iceoryx#261 Avoid code duplication in vector front() and …
c220deb 
…back()

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Apr 26, 2021
@mossmaurice
iox-eclipse-iceoryx#261 Rephrase doxygen about mutex
da0c19f 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Apr 26, 2021
@mossmaurice
iox-eclipse-iceoryx#261 Remove PoshRuntime unit test case from fixtur…
c8ac1c8 
…e and simplify out of bounds check in cxx::vector

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Apr 26, 2021
@mossmaurice
iox-eclipse-iceoryx#261 Add doxygen hint to posix::mutex and adapt re…
d36b33d 
…turn value of AccessController::createACL()

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Apr 26, 2021
@mossmaurice
iox-eclipse-iceoryx#261 Rephrase doxygen comment in allocator
126c9b7 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
@mossmaurice mossmaurice moved this from To do to In progress in v2.x Apr 27, 2021
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Apr 27, 2021
@mossmaurice
iox-eclipse-iceoryx#261 Add doxygen note for methods which can lead t…
ba2d49a 
…o termination

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Apr 27, 2021
@mossmaurice
iox-eclipse-iceoryx#261 Simplify expected handling in AccessControlle…
6c4c1b8 
…r, use attention doxygen tag and remove redundant comments

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Apr 27, 2021
@mossmaurice
iox-eclipse-iceoryx#261 attention all the things
d56fef8 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/iceoryx that referenced this issue Apr 28, 2021
@mossmaurice
iox-eclipse-iceoryx#261 Update copyright info
6e8ad63 
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Sprints automation moved this from In progress to Done Apr 29, 2021
v2.x automation moved this from In progress to Done Apr 29, 2021
mossmaurice added a commit that referenced this issue Apr 29, 2021
@mossmaurice
Merge pull request #750 from ApexAI/iox-#261-replace-std-terminate
ebf5140 
Iox #261 Replace std::terminate with Expects/Ensures
@mossmaurice mossmaurice mentioned this issue May 5, 2021
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mossmaurice mossmaurice

Labels
refactoring Refactor code without adding features
Projects
v2.x
Done
Sprints
Done
Milestone
Medium prio
Development

Successfully merging a pull request may close this issue.

Iox #261 Replace std::terminate with Expects/Ensures ApexAI/iceoryx
1 participant
@mossmaurice