Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check the files have a copyright header #346

Closed
jpsamper2009 opened this issue Nov 10, 2020 · 0 comments · Fixed by #347
Closed

Check the files have a copyright header #346

jpsamper2009 opened this issue Nov 10, 2020 · 0 comments · Fixed by #347
Assignees
@jpsamper2009
Labels
enhancement New feature

Comments

@jpsamper2009
Copy link
Contributor

Brief feature description

To keep contributors happy and acknowledged, we should check that files have an appropriate copyright header.

Detailed information

Details

  • We could use ament_copyright which already comes with a good list of open-source licenses (see template directory)
  • If in the future we need a copyright header different from those provided by ament_copyright, we can create a small python package that extends the available copyright headers
@mossmaurice mossmaurice added the enhancement New feature label Nov 10, 2020
@elBoberido elBoberido linked a pull request Nov 10, 2020 that will close this issue
Iox-#346 Add copyright header check #347
Merged
jpsamper2009 added a commit to ApexAI/iceoryx that referenced this issue Nov 10, 2020
@jpsamper2009
iox-eclipse-iceoryx#346 Cleanup: Remove trailing whitespace in Github…
264b1ad 
… Actions files

Signed-off-by: Juan Pablo Samper <jpsamper2009@gmail.com>
jpsamper2009 added a commit to ApexAI/iceoryx that referenced this issue Nov 10, 2020
@jpsamper2009
iox-eclipse-iceoryx#346 Add CI check for copyright headers
3121c93 
Signed-off-by: Juan Pablo Samper <jpsamper2009@gmail.com>
jpsamper2009 added a commit to ApexAI/iceoryx that referenced this issue Nov 10, 2020
@jpsamper2009
iox-eclipse-iceoryx#346 Fix copyright headers with missing period at …
b865ac6 
…the end:

This ensures that the headers match the template in ament_copyright
(https://github.com/ament/ament_lint/tree/master/ament_copyright)

Signed-off-by: Juan Pablo Samper <jpsamper2009@gmail.com>
jpsamper2009 added a commit to ApexAI/iceoryx that referenced this issue Nov 10, 2020
@jpsamper2009
iox-eclipse-iceoryx#346 Fix bad URL in license headers
b497145 
Signed-off-by: Juan Pablo Samper <jpsamper2009@gmail.com>
mossmaurice added a commit that referenced this issue Nov 10, 2020
@mossmaurice
Merge pull request #347 from ApexAI/iox-346-add-copyright-check
5b843ef 
Iox-#346 Add copyright header check
@elBoberido elBoberido mentioned this issue Jan 4, 2021
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpsamper2009 jpsamper2009

Labels
enhancement New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Iox-#346 Add copyright header check ApexAI/iceoryx
2 participants
@mossmaurice @jpsamper2009