New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace introspection threads with PeriodicTask #489

Closed

3 tasks done

elBoberido opened this issue Jan 13, 2021 · 0 comments · Fixed by #490

Closed

3 tasks done

Replace introspection threads with PeriodicTask #489

elBoberido opened this issue Jan 13, 2021 · 0 comments · Fixed by #490

Assignees

Labels

Projects

Member

elBoberido commented Jan 13, 2021 •

edited

Loading

Brief feature description

Use the PeriodicTask to remove the thread from the introspection classes.

Detailed information

Currently the introspection classes spawn an own thread to periodically update their topics. The shutdown of the threads is done by polling a member every 100ms in the port and process introspection and by a condition variable in the mempool introspection.
By using the PeriodicTask, this gets unified and should also speed up the tests where the RouDiEnvironment is used.

Refactor

process introspection
port introspection
mempool introspection

The text was updated successfully, but these errors were encountered:

elBoberido added refactoring Globex labels

elBoberido self-assigned this

elBoberido added this to To do in Sprints via automation

elBoberido moved this from To do to In progress in Sprints

elBoberido added a commit to ApexAI/iceoryx that referenced this issue


          iox-eclipse-iceoryx#489 Add start/stop functionality to PeriodicTask

0e5505f

Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>

elBoberido added a commit to ApexAI/iceoryx that referenced this issue


          iox-eclipse-iceoryx#489 Add start/stop functionality to PeriodicTask

b9ba38b

Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>

elBoberido added a commit to ApexAI/iceoryx that referenced this issue


          iox-eclipse-iceoryx#489 Replace std::thread with PeriodicTask in Proc…

0744e1d

…essIntrospection

Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>

elBoberido added a commit to ApexAI/iceoryx that referenced this issue


          iox-eclipse-iceoryx#489 Replace std::thread with PeriodicTask in Port…

71543f1

…Introspection

Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>

elBoberido mentioned this issue

Iox #489 replace introspection threads with periodic task #490

Merged

19 tasks

elBoberido added a commit to ApexAI/iceoryx that referenced this issue


          iox-eclipse-iceoryx#489 Update copyright

9fc9fbf

Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>

elBoberido added a commit to ApexAI/iceoryx that referenced this issue


          iox-eclipse-iceoryx#489 Update PeriodicTask documentation

8866af4

Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>

elBoberido added a commit to ApexAI/iceoryx that referenced this issue


          iox-eclipse-iceoryx#489 Add tests for new PeriodicTask functionality

be57986

Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>

elBoberido moved this from In progress to Review in Sprints

elBoberido added a commit to ApexAI/iceoryx that referenced this issue


          iox-eclipse-iceoryx#489 Replace std::thread with PeriodicTask in MemP…

5aaa515

…oolIntrospection

Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>

elBoberido added a commit to ApexAI/iceoryx that referenced this issue


          iox-eclipse-iceoryx#489 Inline template methods

1dd851a

Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>

elBoberido added a commit to ApexAI/iceoryx that referenced this issue


          iox-eclipse-iceoryx#489 Inline template methods in PeriodicTask

58cf6ed

Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>

elBoberido added a commit to ApexAI/iceoryx that referenced this issue


          iox-eclipse-iceoryx#489 Remove '#define private public' from introspe…

3e1ad66

…ction tests

Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>

elfenpiff added a commit to ApexAI/iceoryx that referenced this issue


          iox-eclipse-iceoryx#489 implemented empty UserTrigger default ctor fo…

3ad7ff1

…r msvc

Signed-off-by: Christian Eltzschig <me@elchris.org>

elfenpiff pushed a commit to ApexAI/iceoryx that referenced this issue


          iox-eclipse-iceoryx#489 Inline template methods

6c8b773

Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>

elfenpiff pushed a commit to ApexAI/iceoryx that referenced this issue


          iox-eclipse-iceoryx#489 Inline template methods in PeriodicTask

69ce28d

Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>

elfenpiff pushed a commit to ApexAI/iceoryx that referenced this issue


          iox-eclipse-iceoryx#489 Remove '#define private public' from introspe…

3b495ff

…ction tests

Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>

elfenpiff added a commit to ApexAI/iceoryx that referenced this issue


          Merge branch 'master' of https://github.com/eclipse/iceoryx into iox-e…

c15ed46

…clipse-iceoryx#489-replace-intropection-threads-with-PeriodicTask

elBoberido added a commit to ApexAI/iceoryx that referenced this issue


          iox-eclipse-iceoryx#489 Rename m_sender to m_publishingTask

55f7af9

Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>

elBoberido added a commit to ApexAI/iceoryx that referenced this issue


          iox-eclipse-iceoryx#489 Update PeriodicTask documentation

bf5dbb8

Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>

elBoberido added a commit to ApexAI/iceoryx that referenced this issue


          iox-eclipse-iceoryx#489 Inline template methods

9c0fb9e

Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>

elBoberido added a commit to ApexAI/iceoryx that referenced this issue


          iox-eclipse-iceoryx#489 Inline template methods in PeriodicTask

601b090

Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>

elBoberido added a commit to ApexAI/iceoryx that referenced this issue


          iox-eclipse-iceoryx#489 Remove '#define private public' from introspe…

…ction tests

Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>

elBoberido added a commit to ApexAI/iceoryx that referenced this issue


          iox-eclipse-iceoryx#489 Rename m_sender to m_publishingTask

c98ef7b

Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>

elBoberido added a commit to ApexAI/iceoryx that referenced this issue


          iox-eclipse-iceoryx#489 Update PeriodicTask documentation

d9872a0

Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>

elBoberido added a commit to ApexAI/iceoryx that referenced this issue


          iox-eclipse-iceoryx#489 Add noexcept specifier to methods of introspe…

44558df

…ction classes

Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>

elBoberido added a commit to ApexAI/iceoryx that referenced this issue


          iox-eclipse-iceoryx#489 Clarify which ctor immediatelly starts the task

98ef118

Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>

elBoberido added a commit to ApexAI/iceoryx that referenced this issue


          iox-eclipse-iceoryx#489 Use rhs and lhs in Duration where applicable

d547365

Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>

elBoberido closed this as completed in #490

Sprints automation moved this from Review to Done

elBoberido added a commit that referenced this issue


          Merge pull request #490 from ApexAI/iox-#489-replace-intropection-thr…

6e5c6dd

…eads-with-PeriodicTask

Iox #489 replace introspection threads with periodic task

elBoberido added a commit to ApexAI/iceoryx that referenced this issue


          iox-eclipse-iceoryx#489 Use rhs and lhs in Duration where applicable

4047cfc

Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>

elBoberido added a commit to ApexAI/iceoryx that referenced this issue


          iox-eclipse-iceoryx#489 Use rhs and lhs in Duration where applicable

51bbd1f

Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment