Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add [[nodiscard]] keyword to cxx::expected class #624

Closed
elfenpiff opened this issue Mar 22, 2021 · 2 comments · Fixed by #628
Closed

add [[nodiscard]] keyword to cxx::expected class #624

elfenpiff opened this issue Mar 22, 2021 · 2 comments · Fixed by #628
Assignees
@elfenpiff
Projects
v1.0
Milestone
High prio

Comments

@elfenpiff
Copy link
Contributor

Brief feature description

When a method is returning a cxx::expected it should never be ignored. The [[nodiscard]] keyword ensures that the user performs at least some kind of error handling.
@elfenpiff elfenpiff added this to the Prio 2 milestone Mar 22, 2021
@elfenpiff elfenpiff added this to To do in v1.0 via automation Mar 22, 2021
@elfenpiff elfenpiff self-assigned this Mar 22, 2021
@mossmaurice
Copy link
Contributor

As [[nodiscard]] is only available from C++17 we might want to use GCC's __attribute__((warn_unused_result)). However, we need to check the QNX manual if that is supported as well.

@elfenpiff
Copy link
Contributor Author

here i would suggest wrapping this is an IOX_NODISCARD which then selects [[nodiscard]] for mac os and windows, and the attribute for gcc

elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 22, 2021
@elfenpiff
iox-eclipse-iceoryx#624 added IOX_NO_DISCARD macro and integrated it …
2abcc83 
…in errorHandler usage and unit tests

Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 22, 2021
@elfenpiff
iox-eclipse-iceoryx#624 integrated nodiscard expected in the remainin…
68587b2 
…g unit tests

Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 23, 2021
@elfenpiff
Merge branch 'iox-eclipse-iceoryx#625-fix-file-lock-directory' into iox-
b3606f4 
eclipse-iceoryx#624-add-nodiscard-keyword-to-expected
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 23, 2021
@elfenpiff
iox-eclipse-iceoryx#624 adjusted unit tests to enforced error handlin…
a75490a 
…g with expected

Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 23, 2021
@elfenpiff
iox-eclipse-iceoryx#624 adjusted port pool test to check its created …
01bc772 
…products

Signed-off-by: Christian Eltzschig <me@elchris.org>
@elfenpiff elfenpiff mentioned this issue Mar 23, 2021
Merged
20 tasks
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 23, 2021
@elfenpiff
iox-eclipse-iceoryx#624 specified compiler version on when the keywor…
afe2a77 
…d should be activated

Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 23, 2021
@elfenpiff
iox-eclipse-iceoryx#624 included IceoryxPlatform in examples so that …
e063543 
…we have the ICEORYX_WARNINGS available

Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 23, 2021
@elfenpiff
iox-eclipse-iceoryx#624 fixed warnings in all examples
2b4e397 
Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 23, 2021
@elfenpiff
iox-eclipse-iceoryx#624 updated example readmes after example bugfixes
85dd43c 
Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 23, 2021
@elfenpiff
iox-eclipse-iceoryx#624 added U to mq_send in iceperf example to fix …
0e13e0f 
…conversion warning

Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 23, 2021
@elfenpiff
iox-eclipse-iceoryx#624 ignoring write( return value in a different w…
7ff1768 
…ay for ubuntu

Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 23, 2021
@elfenpiff
iox-eclipse-iceoryx#624 fixed conversion warning in callback subscrib…
00f7ea3 
…er example

Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 23, 2021
@elfenpiff
iox-eclipse-iceoryx#624 fixing unused result warning in dds gateway apps
38d9d6b 
Signed-off-by: Christian Eltzschig <me@elchris.org>
@elfenpiff elfenpiff modified the milestones: Prio 2, Prio 1 Mar 23, 2021
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 23, 2021
@elfenpiff
iox-eclipse-iceoryx#624 fixed unused warning in untyped publisher, us…
b03015b 
…ing IOX_DISCARD_RESULT instead of c style (void) cast

Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 23, 2021
@elfenpiff
Merge branch 'iox-eclipse-iceoryx#624-add-nodiscard-keyword-to-expect…
e789e7f 
…ed' of github.com:ApexAI/iceoryx into iox-eclipse-iceoryx#624-add-nodiscard-keyword-to-expected
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 23, 2021
@elfenpiff
iox-eclipse-iceoryx#624 fixed another unused warning which only occur…
4a74161 
…s in Release build

Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 23, 2021
@elfenpiff
iox-eclipse-iceoryx#624 adding IOX_DISCARD_RESULT to unused values
47ddf93 
Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 23, 2021
@elfenpiff
iox-eclipse-iceoryx#624 terminate on fatal errors, work minimalistic …
e50c3ae 
…with error value in publisher example

Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 23, 2021
@elfenpiff
iox-eclipse-iceoryx#624 added copyright headers, fixed doxygen commen…
2dc4a72 
…ts, using error handler instead of terminate

Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 24, 2021
@elfenpiff
iox-eclipse-iceoryx#624 merged with master and fixed DISCARD_RESULT
fbd9bc6 
Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 24, 2021
@elfenpiff
iox-eclipse-iceoryx#624 fixed some unhandled expecteds
f9b6509 
Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 24, 2021
@elfenpiff
iox-eclipse-iceoryx#624 adjusted year in copyright header
8efe5ac 
Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Mar 24, 2021
@elfenpiff
Merge branch 'iox-eclipse-iceoryx#624-add-nodiscard-keyword-to-expect…
9363d0d 
…ed' into iox-eclipse-iceoryx#350-waitset-with-notification-trace
v1.0 automation moved this from To do to Done Mar 24, 2021
elfenpiff added a commit that referenced this issue Mar 24, 2021
@elfenpiff
Merge pull request #628 from ApexAI/iox-#624-add-nodiscard-keyword-to…
82bb638 
…-expected

Iox #624 add nodiscard keyword to expected
marthtz pushed a commit to boschglobal/iceoryx that referenced this issue May 12, 2021
@elfenpiff @marthtz
iox-eclipse-iceoryx#624 added IOX_NO_DISCARD macro and integrated it …
c71b92a 
…in errorHandler usage and unit tests

Signed-off-by: Christian Eltzschig <me@elchris.org>
marthtz pushed a commit to boschglobal/iceoryx that referenced this issue May 12, 2021
@elfenpiff @marthtz
iox-eclipse-iceoryx#624 integrated nodiscard expected in the remainin…
707817e 
…g unit tests

Signed-off-by: Christian Eltzschig <me@elchris.org>
marthtz pushed a commit to boschglobal/iceoryx that referenced this issue May 12, 2021
@elfenpiff @marthtz
Merge branch 'iox-eclipse-iceoryx#625-fix-file-lock-directory' into iox-
a2577e7 
eclipse-iceoryx#624-add-nodiscard-keyword-to-expected
marthtz pushed a commit to boschglobal/iceoryx that referenced this issue May 12, 2021
@elfenpiff @marthtz
iox-eclipse-iceoryx#624 adjusted unit tests to enforced error handlin…
33626f9 
…g with expected

Signed-off-by: Christian Eltzschig <me@elchris.org>
marthtz pushed a commit to boschglobal/iceoryx that referenced this issue May 12, 2021
@elfenpiff @marthtz
iox-eclipse-iceoryx#624 adjusted port pool test to check its created …
ffbe7a2 
…products

Signed-off-by: Christian Eltzschig <me@elchris.org>
marthtz pushed a commit to boschglobal/iceoryx that referenced this issue May 12, 2021
@elfenpiff @marthtz
iox-eclipse-iceoryx#624 specified compiler version on when the keywor…
911bd7b 
…d should be activated

Signed-off-by: Christian Eltzschig <me@elchris.org>
marthtz pushed a commit to boschglobal/iceoryx that referenced this issue May 12, 2021
@elfenpiff @marthtz
iox-eclipse-iceoryx#624 included IceoryxPlatform in examples so that …
b969fb6 
…we have the ICEORYX_WARNINGS available

Signed-off-by: Christian Eltzschig <me@elchris.org>
marthtz pushed a commit to boschglobal/iceoryx that referenced this issue May 12, 2021
@elfenpiff @marthtz
iox-eclipse-iceoryx#624 fixed warnings in all examples
48bccdd 
Signed-off-by: Christian Eltzschig <me@elchris.org>
marthtz pushed a commit to boschglobal/iceoryx that referenced this issue May 12, 2021
@elfenpiff @marthtz
iox-eclipse-iceoryx#624 updated example readmes after example bugfixes
f8f64c2 
Signed-off-by: Christian Eltzschig <me@elchris.org>
marthtz pushed a commit to boschglobal/iceoryx that referenced this issue May 12, 2021
@elfenpiff @marthtz
iox-eclipse-iceoryx#624 added U to mq_send in iceperf example to fix …
abc7939 
…conversion warning

Signed-off-by: Christian Eltzschig <me@elchris.org>
marthtz pushed a commit to boschglobal/iceoryx that referenced this issue May 12, 2021
@elfenpiff @marthtz
iox-eclipse-iceoryx#624 ignoring write( return value in a different w…
16a5e8f 
…ay for ubuntu

Signed-off-by: Christian Eltzschig <me@elchris.org>
marthtz pushed a commit to boschglobal/iceoryx that referenced this issue May 12, 2021
@elfenpiff @marthtz
iox-eclipse-iceoryx#624 fixed conversion warning in callback subscrib…
0ccf9f7 
…er example

Signed-off-by: Christian Eltzschig <me@elchris.org>
marthtz pushed a commit to boschglobal/iceoryx that referenced this issue May 12, 2021
@elfenpiff @marthtz
iox-eclipse-iceoryx#624 fixing unused result warning in dds gateway apps
4c6e0a2 
Signed-off-by: Christian Eltzschig <me@elchris.org>
marthtz pushed a commit to boschglobal/iceoryx that referenced this issue May 12, 2021
@elfenpiff @marthtz
iox-eclipse-iceoryx#624 fixed unused warning in untyped publisher, us…
51cbf5d 
…ing IOX_DISCARD_RESULT instead of c style (void) cast

Signed-off-by: Christian Eltzschig <me@elchris.org>
marthtz pushed a commit to boschglobal/iceoryx that referenced this issue May 12, 2021
@elfenpiff @marthtz
Merge branch 'iox-eclipse-iceoryx#624-add-nodiscard-keyword-to-expect…
804f3f7 
…ed' of github.com:ApexAI/iceoryx into iox-eclipse-iceoryx#624-add-nodiscard-keyword-to-expected
marthtz pushed a commit to boschglobal/iceoryx that referenced this issue May 12, 2021
@elfenpiff @marthtz
iox-eclipse-iceoryx#624 fixed another unused warning which only occur…
882c368 
…s in Release build

Signed-off-by: Christian Eltzschig <me@elchris.org>
marthtz pushed a commit to boschglobal/iceoryx that referenced this issue May 12, 2021
@elfenpiff @marthtz
iox-eclipse-iceoryx#624 adding IOX_DISCARD_RESULT to unused values
c8bb12d 
Signed-off-by: Christian Eltzschig <me@elchris.org>
marthtz pushed a commit to boschglobal/iceoryx that referenced this issue May 12, 2021
@elfenpiff @marthtz
iox-eclipse-iceoryx#624 terminate on fatal errors, work minimalistic …
3f4a976 
…with error value in publisher example

Signed-off-by: Christian Eltzschig <me@elchris.org>
marthtz pushed a commit to boschglobal/iceoryx that referenced this issue May 12, 2021
@elfenpiff @marthtz
iox-eclipse-iceoryx#624 added copyright headers, fixed doxygen commen…
c4251a4 
…ts, using error handler instead of terminate

Signed-off-by: Christian Eltzschig <me@elchris.org>
marthtz pushed a commit to boschglobal/iceoryx that referenced this issue May 12, 2021
@elfenpiff @marthtz
iox-eclipse-iceoryx#624 merged with master and fixed DISCARD_RESULT
0b1c49b 
Signed-off-by: Christian Eltzschig <me@elchris.org>
marthtz pushed a commit to boschglobal/iceoryx that referenced this issue May 12, 2021
@elfenpiff @marthtz
iox-eclipse-iceoryx#624 fixed some unhandled expecteds
1289115 
Signed-off-by: Christian Eltzschig <me@elchris.org>
marthtz pushed a commit to boschglobal/iceoryx that referenced this issue May 12, 2021
@elfenpiff @marthtz
iox-eclipse-iceoryx#624 adjusted year in copyright header
e6aca1d 
Signed-off-by: Christian Eltzschig <me@elchris.org>
marthtz pushed a commit to boschglobal/iceoryx that referenced this issue May 12, 2021
@elfenpiff @marthtz
Merge pull request eclipse-iceoryx#628 from ApexAI/iox-#624-add-nodis…
a3dc488 
…card-keyword-to-expected

Iox eclipse-iceoryx#624 add nodiscard keyword to expected
marthtz pushed a commit to boschglobal/iceoryx that referenced this issue May 12, 2021
@elfenpiff @marthtz
Merge branch 'iox-eclipse-iceoryx#624-add-nodiscard-keyword-to-expect…
f2288f1 
…ed' into iox-eclipse-iceoryx#350-waitset-with-notification-trace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elfenpiff elfenpiff

Labels
None yet
Projects
No open projects
v1.0
  
Done
Milestone
High prio
Development

Successfully merging a pull request may close this issue.

Iox #624 add nodiscard keyword to expected ApexAI/iceoryx
2 participants
@mossmaurice @elfenpiff