Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usage of github actions to build pull requests #89

Closed
budrus opened this issue Apr 22, 2020 · 0 comments · Fixed by #97
Closed

Usage of github actions to build pull requests #89

budrus opened this issue Apr 22, 2020 · 0 comments · Fixed by #97
Labels
enhancement New feature good first issue Good for newcomers

Comments

@budrus
Copy link
Contributor

budrus commented Apr 22, 2020

Brief feature description

External Jenkins jobs are used to build and test the pull requests. Usage of github actions would be better,

Detailed information

With the actions, github provides the infrastructure do build the pull requests, this is much more transparent than using external Jenkins servers. The pull requests are also better documented then. In the rmw_iceoryx they were already introduced. We should also use them here.
e.g. see https://github.com/ros2/rmw_iceoryx/blob/master/.github/workflows/main.yml
@budrus budrus added enhancement New feature good first issue Good for newcomers labels Apr 22, 2020
prasannabhat added a commit to prasannabhat/iceoryx that referenced this issue May 10, 2020
@prasannabhat
iox-eclipse-iceoryx#89 add github workflow for build & test
cfca1d8
prasannabhat added a commit to prasannabhat/iceoryx that referenced this issue May 10, 2020
@prasannabhat
iox-eclipse-iceoryx#89 add github workflow for build & test
5b3b564 
Signed-off-by: Prasanna Bhat <prasanna.yoga@gmail.com>
@prasannabhat prasannabhat mentioned this issue May 10, 2020
Merged
elBoberido added a commit that referenced this issue May 13, 2020
@elBoberido
Merge pull request #97 from prasannabhat/iox-#89-github-actions
f4e368e 
iox-#89 add github workflow for build & test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

iox-#89 add github workflow for build & test prasannabhat/iceoryx
1 participant
@budrus