-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#590 Separate errors of posh and C binding #1028
iox-#590 Separate errors of posh and C binding #1028
Conversation
…er() calls from hoofs Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
… errorHandler() call Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
5fb53c5
to
9648c38
Compare
|
||
enum class CBindingError : uint32_t | ||
{ | ||
kNO_ERROR = 2000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is one solution to the question "How to make the enum values unique all over iceoryx?" As modules aka CMake packages are seldomly created, I think this approach is ok as an intermediate step till we further work on the error handling (like DLT support). Another possibility would be to add an additional argument to the call with a component id.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please keep this PR on hold until we figured out how the overall error concept in iceoryx looks like.
To call terminate is most likely not an option for ASIL D and we may have to make this either configurable or that some user can define custom callbacks to notify maybe some kind of watchdog or even throw an exception.
In those cases an error handler may is the more viable solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You checked the PR title check but the title does not follow our guidelines. Please add iox-#???
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please perform the renaming of error_handling.hpp
into error_handler.hpp
in a separate PR.
This PR will be rebased onto #1100. Please refrain from reviewing it. I'll leave it open until there is a replacement to link to. |
Superseded by #1170 |
Pre-Review Checklist for the PR Author
iox-#123-this-is-a-branch
)iox-#123 commit text
)git commit -s
)task-list-completed
)Notes for Reviewer
Todo
errorHandler()
call so that callable is last to avoidnullptr
argDiscussion
errorHandler()
call?k
in front of the errors?Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References