Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#590 Move unused and quality level 2 classes to separate packages #1559

Conversation

mossmaurice
Copy link
Contributor

@mossmaurice mossmaurice commented Aug 2, 2022

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. All touched (C/C++) source code files are added to ./clang-tidy-diff-scans.txt
  11. Assign PR to reviewer

Notes for Reviewer

  • Move unused files to separate repository in the iceoryx organisaton
  • Move quality level 2 classes to new package iceoryx_dust (Deemed useful software thingies)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@mossmaurice mossmaurice added the refactoring Refactor code without adding features label Aug 2, 2022
@mossmaurice mossmaurice self-assigned this Aug 2, 2022
@mossmaurice mossmaurice force-pushed the iox-#590-move-unused-classes-to-separate-package branch from 0b5b551 to 303f0e1 Compare August 2, 2022 22:33
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #1559 (e63815c) into master (70ec584) will decrease coverage by 3.84%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1559      +/-   ##
==========================================
- Coverage   78.95%   75.10%   -3.85%     
==========================================
  Files         379      369      -10     
  Lines       14486    14224     -262     
  Branches     2028     1988      -40     
==========================================
- Hits        11437    10683     -754     
- Misses       2421     2952     +531     
+ Partials      628      589      -39     
Flag Coverage Δ
unittests 74.76% <ø> (-3.86%) ⬇️
unittests_timing 15.17% <ø> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
iceoryx_dds/source/gateway/main.cpp 0.00% <ø> (ø)
...oryx_dust/include/iceoryx_dust/cxx/file_reader.hpp 100.00% <ø> (ø)
...eoryx_dust/include/iceoryx_dust/cxx/objectpool.hpp 24.84% <ø> (ø)
...include/iceoryx_dust/internal/cxx/forward_list.inl 0.00% <ø> (ø)
.../include/iceoryx_dust/posix_wrapper/named_pipe.hpp 0.00% <ø> (ø)
...lude/iceoryx_dust/posix_wrapper/signal_watcher.hpp 0.00% <ø> (ø)
...eoryx_dust/relocatable_pointer/relocatable_ptr.inl 0.00% <ø> (ø)
iceoryx_dust/source/cxx/file_reader.cpp 38.09% <ø> (ø)
...ceoryx_dust/source/posix_wrapper/message_queue.cpp 0.00% <ø> (ø)
iceoryx_dust/source/posix_wrapper/named_pipe.cpp 0.00% <ø> (ø)
... and 21 more

@mossmaurice mossmaurice force-pushed the iox-#590-move-unused-classes-to-separate-package branch from 448c742 to 62368ee Compare August 4, 2022 13:11
Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just minor things

…ceoryx_dust and unused files to separate repository

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
… Windows

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
@mossmaurice mossmaurice force-pushed the iox-#590-move-unused-classes-to-separate-package branch from 5030ed9 to 8497de3 Compare August 4, 2022 18:34
@mossmaurice mossmaurice marked this pull request as ready for review August 4, 2022 18:34
elBoberido
elBoberido previously approved these changes Aug 4, 2022
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
@mossmaurice mossmaurice merged commit be2272f into eclipse-iceoryx:master Aug 8, 2022
@mossmaurice mossmaurice deleted the iox-#590-move-unused-classes-to-separate-package branch August 8, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactor code without adding features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve modularity by creating architecure guidelines
3 participants