New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#590 Move unused and quality level 2 classes to separate packages #1559
Merged
mossmaurice
merged 24 commits into
eclipse-iceoryx:master
from
ApexAI:iox-#590-move-unused-classes-to-separate-package
Aug 8, 2022
Merged
iox-#590 Move unused and quality level 2 classes to separate packages #1559
mossmaurice
merged 24 commits into
eclipse-iceoryx:master
from
ApexAI:iox-#590-move-unused-classes-to-separate-package
Aug 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mossmaurice
force-pushed
the
iox-#590-move-unused-classes-to-separate-package
branch
from
August 2, 2022 22:33
0b5b551
to
303f0e1
Compare
Codecov Report
@@ Coverage Diff @@
## master #1559 +/- ##
==========================================
- Coverage 78.95% 75.10% -3.85%
==========================================
Files 379 369 -10
Lines 14486 14224 -262
Branches 2028 1988 -40
==========================================
- Hits 11437 10683 -754
- Misses 2421 2952 +531
+ Partials 628 589 -39
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mossmaurice
force-pushed
the
iox-#590-move-unused-classes-to-separate-package
branch
from
August 4, 2022 13:11
448c742
to
62368ee
Compare
elBoberido
reviewed
Aug 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just minor things
iceoryx_hoofs/platform/win/include/iceoryx_hoofs/platform/platform_settings.hpp
Show resolved
Hide resolved
iceoryx_hoofs/platform/win/include/iceoryx_hoofs/platform/platform_settings.hpp
Show resolved
Hide resolved
iceoryx_posh/include/iceoryx_posh/internal/runtime/ipc_interface_base.hpp
Outdated
Show resolved
Hide resolved
iceoryx_posh/include/iceoryx_posh/internal/runtime/ipc_interface_base.hpp
Outdated
Show resolved
Hide resolved
…ceoryx_dust and unused files to separate repository Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
… Windows Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice
force-pushed
the
iox-#590-move-unused-classes-to-separate-package
branch
from
August 4, 2022 18:34
5030ed9
to
8497de3
Compare
elBoberido
previously approved these changes
Aug 4, 2022
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
elBoberido
approved these changes
Aug 5, 2022
dkroenke
approved these changes
Aug 8, 2022
mossmaurice
deleted the
iox-#590-move-unused-classes-to-separate-package
branch
August 8, 2022 08:53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch
)iox-#123 commit text
)git commit -s
)task-list-completed
)./clang-tidy-diff-scans.txt
Notes for Reviewer
iceoryx_dust
(Deemed useful software thingies)Checklist for the PR Reviewer
./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References