Iox #15 add docker environment #16
Conversation
Mr-Slippery
force-pushed
the
iox-#15-add-docker-environment
branch
from
86c19df
to
fc1452a
Compare
|
|
||
| WORKDIR /iceoryx | ||
|
|
||
| RUN ./tools/iceoryx_build_test.sh \ |
There was a problem hiding this comment.
In your original version (https://github.com/Mr-Slippery/iceoryx-dockerfiles/blob/master/Dockerfile) you were cloning iceoryx before executing this script. How is the script coming in the docker container?
There was a problem hiding this comment.
Hi @mossmaurice, indeed, initially I was cloning, but for this "integrated version", I thought it makes sense to build and include into the container the current source that is cloned. This makes it into the container via ADD . / in the Dockerfile.
There was a problem hiding this comment.
But now that you mention it, there is perhaps an issue here, maybe some unintended things make it inside as well, I'll check and fix this. In my case the source was in an otherwise empty dir.
There was a problem hiding this comment.
Updated now, indeed, there was an issue, I was going to the parent of top-level iceoryx and adding everything into Docker /. Now I just go to iceoryx and add its content into Docker /iceoryx. Rebased branch, melded changes into existing commit. Thanks for the catch!
| Receiving: 81 | ||
| ``` | ||
|
|
||
| ## Using `screen` to launch RouDi and examples |
tools/docker/.screenrc
Outdated
| @@ -0,0 +1 @@ | |||
| shell "/bin/bash" | |||
There was a problem hiding this comment.
I'm quite fond of fish. Could we use it here?
There was a problem hiding this comment.
I don't see any problem, could install fish as extra package just like screen. I'll give it a try.
There was a problem hiding this comment.
Changed the screen shell to fish now (rebased/melded changes).
Welcome to fish, the friendly interactive shell
root@252a62dfbf2e /iceoryx# ./build/iceoryx_examples/icedelivery/ice_sender
Sending: 0
Sending: 1
Sending: 2
Sending: 3
Mr-Slippery
force-pushed
the
iox-#15-add-docker-environment
branch
from
fc1452a
to
62a8057
Compare
Create a Docker image with a built iceoryx library, RouDi daemon, and example applications. Also provide a way to launch Docker containers in which the RouDi daemon and example applications can be run. Main work is done in the Dockerfile and the build_and_run.sh script. The .screenrc file is just configuring screen to use bash as its shell. This is convenient in case screen is used to run the daemon and examples. The README.md documents the feature and suggested usage patterns. Issues: iox-eclipse-iceoryx#15 Signed-off-by: Cornel Izbasa <badc0ded@gmail.com>
Issues: iox-eclipse-iceoryx#15 Signed-off-by: Cornel Izbasa <badc0ded@gmail.com>
Mr-Slippery
force-pushed
the
iox-#15-add-docker-environment
branch
from
62a8057
to
05fd4df
Compare
| @@ -0,0 +1,34 @@ | |||
| # Copyright (c) 2019 by Cornel Izbasa. All rights reserved. | |||
There was a problem hiding this comment.
I guess this is you @Mr-Slippery? I need to confirm that we have the approval from the Author to use this codesnippet.
There was a problem hiding this comment.
Hi @dkroenke, yes, it's just my Github username. :) The Eclipse account linked to this Github username has my real name, Cornel Izbasa. Thanks!
There was a problem hiding this comment.
Are you maybe located in Berlin? I found a LinkedIn Profile which says that you are in Tempelhof.
There was a problem hiding this comment.
I work at HELLA in Tempelhof, but live in North-East of Berlin :)
|
@dkroenke absolutely agree with the docker-compose follow-up, for starters I just didn't want to ask too much of the user, except to have Docker installed and then be able to build and run the apps. And if the image is published on Docker Hub then it will be even easier. |
This adds a Docker environment for building and running iceoryx applications as described in #15.
It suggests a usage pattern based on
docker execand one based onscreen, depending on preference and configuration.Further details are on the description of related issue #15 and inside the added documentation files.
Thanks for your kind feedback!