iox-#341 implemented condition variable cleanup in waitset destructor #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tset destructor Signed-off-by: Christian Eltzschig <me@elchris.org>
budrus
approved these changes
Dec 17, 2020
elBoberido
reviewed
Dec 17, 2020
| @@ -49,7 +49,7 @@ class iox_user_trigger_test : public Test | |||
| iox_user_trigger_storage_t m_sutStorage; | |||
| iox_user_trigger_t m_sut; | |||
|
|
|||
| ConditionVariableData m_condVar; | |||
| ConditionVariableData m_condVar{"Horscht"}; | |||
|
|
||
| auto interfacePointer = m_portManager->acquireInterfacePortData(iox::capro::Interfaces::INTERNAL, "itfPenguin"); | ||
| EXPECT_THAT(interfacePointer, Eq(nullptr)); | ||
| EXPECT_TRUE(errorHandlerCalled); |
There was a problem hiding this comment.
in the PublisherOverflow the correct error code is also tested. Shouldn't this be done here too?
There was a problem hiding this comment.
Not possible since this returns just a pointer and not an expected. There is a todo in the code to change this.
| { | ||
| std::vector<iox::popo::ConditionVariableData*> condVarContainer; | ||
|
|
||
| std::string process = "HypnoToadForEver"; |
elBoberido
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christian Eltzschig me@elchris.org
Pre-Review Checklist for the PR Author
iox-#123-this-is-a-branch)iox-#123 commit text)git commit -s)Notes for Reviewer
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
Post-review Checklist for the Eclipse Committer
References