New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iox #954 use cxx::expected for MemoryManager::getChunk #991
Iox #954 use cxx::expected for MemoryManager::getChunk #991
Conversation
iceoryx_posh/include/iceoryx_posh/internal/popo/building_blocks/chunk_sender.hpp
Outdated
Show resolved
Hide resolved
28af990
to
8375cc3
Compare
Codecov Report
@@ Coverage Diff @@
## master #991 +/- ##
==========================================
- Coverage 77.75% 77.70% -0.06%
==========================================
Files 336 337 +1
Lines 12362 12395 +33
Branches 1839 1841 +2
==========================================
+ Hits 9612 9631 +19
- Misses 2125 2137 +12
- Partials 625 627 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
a3e2128
to
0dbf3fa
Compare
iceoryx_posh/include/iceoryx_posh/internal/mepoo/memory_manager.inl
Outdated
Show resolved
Hide resolved
iceoryx_posh/include/iceoryx_posh/internal/popo/building_blocks/chunk_sender.hpp
Outdated
Show resolved
Hide resolved
iceoryx_posh/include/iceoryx_posh/internal/popo/building_blocks/chunk_sender.inl
Show resolved
Hide resolved
1f47b2c
to
460b126
Compare
3404a7c
to
a66e8f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, two minor findings.
iceoryx_posh/include/iceoryx_posh/internal/popo/building_blocks/chunk_sender.hpp
Outdated
Show resolved
Hide resolved
iceoryx_posh/include/iceoryx_posh/internal/mepoo/memory_manager.inl
Outdated
Show resolved
Hide resolved
a66e8f4
to
85abc2f
Compare
85abc2f
to
06c00de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…yManager::getChunk and adjust tests
316a693
to
0901c4e
Compare
Pre-Review Checklist for the PR Author
iox-#123-this-is-a-branch
)iox-#123 commit text
)git commit -s
)task-list-completed
)Notes for Reviewer
This PR refactors the
MemoryManager::getChunk
method to use the error handling withcxx::expected
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References