Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#210] Restructure examples #216

Merged

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented May 17, 2024

Notes for Reviewer

This PR restructures the examples as preparation for the C language bindings and the C examples.

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Relates to #210

@elBoberido elBoberido requested a review from elfenpiff May 17, 2024 22:55
@elBoberido elBoberido self-assigned this May 17, 2024
@elBoberido elBoberido force-pushed the iox2-210-restructure-examples branch from eabdba2 to cf30bc5 Compare May 17, 2024 23:04
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.11%. Comparing base (82b1baf) to head (cf30bc5).
Report is 16 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
- Coverage   79.23%   79.11%   -0.12%     
==========================================
  Files         183      183              
  Lines       20415    20420       +5     
==========================================
- Hits        16175    16155      -20     
- Misses       4240     4265      +25     
Files Coverage Δ
iceoryx2/src/config.rs 65.17% <ø> (-0.90%) ⬇️

... and 52 files with indirect coverage changes

@elBoberido elBoberido merged commit 7618991 into eclipse-iceoryx:main May 18, 2024
49 checks passed
@elBoberido elBoberido deleted the iox2-210-restructure-examples branch May 18, 2024 00:04
@elBoberido elBoberido linked an issue May 18, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create C language binding
2 participants