Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#266] Configure bindgen to bind dirfd C macro on macOS #267

Conversation

orecham
Copy link
Contributor

@orecham orecham commented Jul 8, 2024

Notes for Reviewer

Forwards calls to dirent to C macro defined on macOS platform.
Only required on macOS as dirent is declared as a function on other platforms.

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Assign PR to reviewer
  8. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Closes #266

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.75%. Comparing base (a83c2ec) to head (18d6c8b).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
- Coverage   79.79%   79.75%   -0.05%     
==========================================
  Files         191      191              
  Lines       21468    21468              
==========================================
- Hits        17130    17121       -9     
- Misses       4338     4347       +9     

see 1 file with indirect coverage changes

@elfenpiff elfenpiff assigned elfenpiff and orecham and unassigned elfenpiff Jul 8, 2024
@elfenpiff elfenpiff self-requested a review July 8, 2024 08:49
@elfenpiff elfenpiff merged commit 9bb5c84 into eclipse-iceoryx:main Jul 8, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bindgen fails to generate binding to dirfd on macOS 14.5
2 participants