Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#210] Create NodeName C API #289

Merged

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Jul 12, 2024

Notes for Reviewer

This PR crates the NodeName C API and introduces a new pattern for the type erasure which is better suited for moving the ownership.

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Relates to #210

@elBoberido elBoberido self-assigned this Jul 12, 2024
@elBoberido elBoberido force-pushed the iox2-210-create-node-name-c-api branch 3 times, most recently from 2b6417a to 22a72bc Compare July 12, 2024 20:51
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.39%. Comparing base (58b6b1b) to head (3f778ad).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #289      +/-   ##
==========================================
+ Coverage   80.35%   80.39%   +0.04%     
==========================================
  Files         191      191              
  Lines       21814    21814              
==========================================
+ Hits        17529    17538       +9     
+ Misses       4285     4276       -9     

see 4 files with indirect coverage changes

@elBoberido elBoberido force-pushed the iox2-210-create-node-name-c-api branch 3 times, most recently from 04caf21 to 619a3a4 Compare July 12, 2024 21:28
@elBoberido elBoberido force-pushed the iox2-210-create-node-name-c-api branch from 619a3a4 to 3f778ad Compare July 12, 2024 21:56
@elBoberido elBoberido merged commit 22357f5 into eclipse-iceoryx:main Jul 12, 2024
53 checks passed
@elBoberido elBoberido deleted the iox2-210-create-node-name-c-api branch July 12, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants