Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install from local packages #21

Merged
merged 3 commits into from Jun 10, 2019
Merged

Install from local packages #21

merged 3 commits into from Jun 10, 2019

Conversation

Pixcell
Copy link
Contributor

@Pixcell Pixcell commented Jun 10, 2019

No description provided.

README.md Outdated Show resolved Hide resolved
.env Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
else
wget -q -O - https://packagecloud.io/install/repositories/iofog/iofog-agent/script.deb.sh | bash
apt-get install iofog-agent
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe there is a way not to have these scripts inside the Dockerfile. The Dockerfile can be the same - just give it some package. It doesn't care where it comes from. Then the script can be outside and Dockerfile can just COPY and RUN dpkg -i

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would also mean the ARG LOCAL_CONNECTOR_PACKAGE is not needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really possible wget -q -O - https://packagecloud.io/install/repositories/iofog/iofog-agent/script.deb.sh | bashActually sets the apt-get repo list. It does not directly download a .deb file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should do the trick

https://packagecloud.io/install/repositories/iofog/iofog-agent/script.deb.sh | bash
apt-get download iofog-agent

start.sh Outdated Show resolved Hide resolved
start.sh Outdated Show resolved Hide resolved
start.sh Outdated Show resolved Hide resolved
@Pixcell Pixcell merged commit 652051f into develop Jun 10, 2019
@Pixcell Pixcell deleted the installFromLocalPackages branch June 12, 2019 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants