Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial PR template #11

Merged
merged 2 commits into from May 12, 2022

Conversation

tsmaeder
Copy link
Contributor

@tsmaeder tsmaeder commented Apr 27, 2022

What it does

Adds a pull request template (#7)

How to test.

You can't really before merging. However, I would welcome a lively discussion on what should be in the template.

Signed-off-by: Thomas Mäder <tmader@redhat.com>
@tsmaeder tsmaeder changed the title Add initial PR template closes #7 Add initial PR template Apr 27, 2022
pull_request_template.md Outdated Show resolved Hide resolved
Signed-off-by: Thomas Mäder <tmader@redhat.com>
@tsmaeder tsmaeder requested a review from mpalat May 5, 2022 09:07
@tsmaeder
Copy link
Contributor Author

tsmaeder commented May 5, 2022

@akurtakov

@gayanper
Copy link

gayanper commented May 5, 2022

Just to have an understanding, Are we making having a github issue optional here ?

@sravanlakkimsetti sravanlakkimsetti merged commit e81ae21 into eclipse-jdt:main May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants