Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance : getMainTypeName in CompilationUnitDeclaration is called very often #1747

Closed
RoiSoleil opened this issue Dec 14, 2023 · 1 comment · Fixed by #1821 or #1831
Closed

Performance : getMainTypeName in CompilationUnitDeclaration is called very often #1747

RoiSoleil opened this issue Dec 14, 2023 · 1 comment · Fixed by #1821 or #1831

Comments

@RoiSoleil
Copy link
Contributor

getMainTypeName in CompilationUnitDeclaration is called very often
add a cash to increase performance

image

@jukzi
Copy link
Contributor

jukzi commented Dec 14, 2023

my sampling says getMainTypeName is irrelevant compared to other things:
image

but maybe you have a special usecase?

jukzi pushed a commit to jukzi/eclipse.jdt.core that referenced this issue Jan 8, 2024
jukzi pushed a commit to jukzi/eclipse.jdt.core that referenced this issue Jan 9, 2024
jukzi pushed a commit to jukzi/eclipse.jdt.core that referenced this issue Jan 9, 2024
…1747

keep Scanner.insideModuleInfo in sync with isParsingModuleDeclaration()

eclipse-jdt#1747
jukzi pushed a commit to jukzi/eclipse.jdt.core that referenced this issue Jan 9, 2024
…1747

keep Scanner.insideModuleInfo in sync with isParsingModuleDeclaration()

eclipse-jdt#1747
@jukzi jukzi linked a pull request Jan 9, 2024 that will close this issue
jukzi pushed a commit to jukzi/eclipse.jdt.core that referenced this issue Jan 9, 2024
…1747

keep Scanner.insideModuleInfo in sync with isParsingModuleDeclaration()

eclipse-jdt#1747
jukzi pushed a commit to jukzi/eclipse.jdt.core that referenced this issue Jan 10, 2024
jukzi pushed a commit that referenced this issue Jan 10, 2024
@jukzi jukzi linked a pull request Jan 10, 2024 that will close this issue
mpalat added a commit that referenced this issue Jan 11, 2024
* [formatter] Align arrows on column in switch statements/expressions (#1817)

* Move the GenerateParserScript.class to correct .gitignore file (#1818)

The GenerateParserScript.class is present in the wrong .gitignore file after the jdt.core.compiler.batch was split from jdt.core bundle. Move it to the correct list.

* [performance] faster TypeHierarchy #1779

Fixes "slow git pull while type hierarchy view is open"
#1779

Use LinkedHashSet / HashSet to avoid linear search on contains().
Javadoc of ITypeHierarchy.getAllSubtypes(IType) states: return "in no
particular order"

tested by TypeHierarchyTests, TypeHierarchySerializationTests

* Touch test bundle affected by TypeHierarchy code change

See #1783
See eclipse-platform/eclipse.platform.releng.aggregator#1704

* Start position and length of Dimension node lost when cloned (#1787)

When a Dimension node is cloned, the start position and length of the
node needs to be explicitly set. Otherwise this information is lost.

Fixes #1786

* Add code completion support for embedded expressions inside text block (#1803)

#1711

* Switch expression fails with instanceof + ternary operator combo

* Fixes #1820

* [performance] less calls to isInModuleDeclaration() #1747

Reorder costly conditions

#1747

* Fix files that have been checked in with \r\n to use only \n

---------

Co-authored-by: Mateusz Matela <mateusz.matela@gmail.com>
Co-authored-by: Jay Arthanareeswaran <jarthana@in.ibm.com>
Co-authored-by: Joerg Kubitz <jkubitz-eclipse@gmx.de>
Co-authored-by: Andrey Loskutov <loskutov@gmx.de>
Co-authored-by: Patrick Ziegler <ziegler.patrick@hotmail.de>
Co-authored-by: Srikanth Sankaran <131454720+srikanth-sankaran@users.noreply.github.com>
Co-authored-by: Ed Merks <ed.merks@gmail.com>
jukzi pushed a commit to jukzi/eclipse.jdt.core that referenced this issue Feb 8, 2024
…1747

keep Scanner.insideModuleInfo in sync with isParsingModuleDeclaration()

eclipse-jdt#1747
jukzi pushed a commit that referenced this issue Feb 12, 2024
keep Scanner.insideModuleInfo in sync with isParsingModuleDeclaration()

#1747
mickaelistria pushed a commit to mickaelistria/eclipse.jdt.core that referenced this issue Feb 16, 2024
…1747

keep Scanner.insideModuleInfo in sync with isParsingModuleDeclaration()

eclipse-jdt#1747
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment