Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19] JEP 405: Record Patterns (First Preview) #85

Closed
jarthana opened this issue May 16, 2022 · 5 comments
Closed

[19] JEP 405: Record Patterns (First Preview) #85

jarthana opened this issue May 16, 2022 · 5 comments
Assignees
Milestone

Comments

@jarthana
Copy link
Member

JEP 405: Record Patterns has been targeted for Java 19 as a preview feature. This will require considerable changes from grammar all the way up to the code generation and DOM model. The specification is here

@kriegaex
Copy link
Contributor

In order to avoid many upstream merges from JDT Core int AspectJ, I would like to wait as long as possible, until only minor changes for Java 19 remain. Are you expecting this to be ready for Java 19 GA on September 20th or shortly thereafter? Of course, I am going to wait as long as it takes, I am just asking.

@jarthana
Copy link
Member Author

In order to avoid many upstream merges from JDT Core int AspectJ, I would like to wait as long as possible, until only minor changes for Java 19 remain. Are you expecting this to be ready for Java 19 GA on September 20th or shortly thereafter? Of course, I am going to wait as long as it takes, I am just asking.

We always merge the language feature changes right after the GA and not before that. Hope this helps.

@kriegaex
Copy link
Contributor

kriegaex commented Sep 16, 2022

Of course you merge after GA, which is fine. But that was not the question. I was unsure about whether this was already implemented or not, because the issue is listed as open. I do not know your GitHub issue status workflow and how you map subtasks to this overarching issue.

What I really wanted to know is if it makes sense for me to merge the BETA_19 branch into the AspectJ fork already. I can always re-merge minor changes later on, I simply wanted to avoid merging major ones 2+ times.

I shall just wait then, sorry for the noise.

@iloveeclipse
Copy link
Member

@jarthana : please close if fixed or set other milestone, BETA_JAVA19 is not valid anymore.

@iloveeclipse iloveeclipse modified the milestones: BETA_JAVA19, BETA_JAVA20 Mar 21, 2023
@mpalat
Copy link
Contributor

mpalat commented Mar 22, 2023

Closing this as #481 is the latest

@mpalat mpalat closed this as completed Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants